Re: [dm-devel] [PATCH blktests v2] tests/dm: add a regression test

2023-05-03 Thread Yu Kuai
Hi, 在 2023/05/01 12:34, Shinichiro Kawasaki 写道: Yu, thanks for the patch. I have three minor comments below. Other than that, the patch looks good to me. If you do not mind, I can do these edits. Please let me know your thoughts. I'm good with your comments. Thanks, Kuai 1) Let's describe a

Re: [dm-devel] [PATCH v5 09/20] gfs2: use __bio_add_page for adding single page to bio

2023-05-03 Thread Bob Peterson
On 5/2/23 6:19 AM, Johannes Thumshirn wrote: The GFS2 superblock reading code uses bio_add_page() to add a page to a newly created bio. bio_add_page() can fail, but the return value is never checked. Use __bio_add_page() as adding a single page to a newly created bio is guaranteed to succeed. T