Re: [dm-devel] [PATCH v4 02/18] block: Rename BLK_STS_NEXUS to BLK_STS_RESV_CONFLICT

2023-03-21 Thread Mike Christie
On 3/20/23 8:06 AM, Christoph Hellwig wrote: > On Thu, Mar 16, 2023 at 11:36:12AM -0500, Mike Christie wrote: >> I think we are ok for dasd using BLK_STS_RESV_CONFLICT. >> >> It thought it sounded similar to SCSI/NVMe and userspace will still >> see -EBADE because the blk_status_to_errno/errno_to_b

Re: [dm-devel] [PATCH v4 07/18] nvme: Fix reservation status related structs

2023-03-21 Thread Mike Christie
On 3/15/23 12:40 AM, Christoph Hellwig wrote: > On Tue, Mar 14, 2023 at 05:23:16PM -0500, Mike Christie wrote: >> We could do separate structs though: > > I suspect that's probably better in the long run, as the [0] notation > is on its way out. Ok. I was able to use the separate structs and then

[dm-devel] [PATCH v2] dm verity: fix error handling for check_at_most_once on FEC

2023-03-21 Thread Yeongjin Gil
In verity_end_io(), if bi_status is not BLK_STS_OK, it can be return directly. But if FEC configured, it is desired to correct the data page through verity_verify_io. And the return value will be converted to blk_status and passed to verity_finish_io(). BTW, when a bit is set in v->validated_block

Re: [dm-devel] [PATCH] multipath-tools Consider making 'smart' the default

2023-03-21 Thread Martin Wilck
On Mon, 2023-03-20 at 14:41 -0500, Benjamin Marzinski wrote: > On Mon, Mar 20, 2023 at 03:18:37PM +0100, Martin Wilck wrote: > > On Thu, 2023-03-16 at 14:47 -0700, Brian Bunker wrote: > > > > > > Subsequent volumes after the first one are discovered via unit > > > attentions triggering the udev r

Re: [dm-devel] [PATCH] libmultipath: limit paths that can get wwid from environment

2023-03-21 Thread Martin Wilck
On Mon, 2023-03-20 at 15:37 -0500, Benjamin Marzinski wrote: > > > > I have to say I don't quite understand why we read from the > > environment > > at all if the libudev call fails. This was coded before I joined > > the > > project, so perhaps you can clarify it. Why do we expect the > > environ

Re: [dm-devel] [PATCH] libmultipath: limit paths that can get wwid from environment

2023-03-21 Thread Martin Wilck
On Thu, 2023-02-09 at 11:28 -0600, Benjamin Marzinski wrote: > Currently, whenever getting the uid_attribute from the udev database > fails, multipath will try to get it from the environment variables. > This > normally isn't a problem, since either multipath -u is getting called > from a uevent an

[dm-devel] [PATCH] dm-bufio: use multi-page bio vector

2023-03-21 Thread Mikulas Patocka
The kernel supports multi page bio vector entries, so we can use them in dm-bufio as an optimization. Signed-off-by: Mikulas Patocka --- drivers/md/dm-bufio.c | 24 1 file changed, 4 insertions(+), 20 deletions(-) Index: linux-2.6/drivers/md/dm-bufio.c ==