Re: [dm-devel] [LSF/MM/BPF TOPIC] Linux Security Summit cross-over?

2023-02-27 Thread Hannes Reinecke
On 2/24/23 22:37, Steve French wrote: I did one on network fs security at a security summit before that would still be relevant to both On Tue, Feb 21, 2023, 16:16 James Bottomley > wrote: On Tue, 2023-02-21 at 16:55 +, David Howells wrot

[dm-devel] [PATCH] Avoid deadlock for recursive I/O on dm-thin when used as swap

2023-02-27 Thread Coly Li
This is an alrady known issue that dm-thin volume cannot be used as swap, otherwise a deadlock may happen when dm-thin internal memory demond triggers swap I/O on the dm-thin volume itself. Thanks to Mikulas Patocka for commit a666e5c05e7c ("dm: fix deadlock when swapping to encrypted device"), th

Re: [dm-devel] [PATCH v2] blk-mq: enforce op-specific segment limits in blk_insert_cloned_request

2023-02-27 Thread Christoph Hellwig
On Thu, Feb 23, 2023 at 12:34:46PM -0700, Uday Shankar wrote: > I chose to add blk_queue_get_max_segments as a public function because > it parallels blk_queue_get_max_sectors. If you don't want two functions, > I could manually inline the (2) uses of blk_rq_get_max_segments(rq), > converting them

[dm-devel] [PATCH v2] Avoid deadlock for recursive I/O on dm-thin when used as swap

2023-02-27 Thread Coly Li
This is an alrady known issue that dm-thin volume cannot be used as swap, otherwise a deadlock may happen when dm-thin internal memory demond triggers swap I/O on the dm-thin volume itself. Thanks to Mikulas Patocka for commit a666e5c05e7c ("dm: fix deadlock when swapping to encrypted device"), th

Re: [dm-devel] dm-crypt: fix softlockup in dmcrypt_write

2023-02-27 Thread Mike Snitzer
On Sun, Feb 26 2023 at 8:31P -0500, yangerkun wrote: > > > 在 2023/2/26 10:01, Bart Van Assche 写道: > > On 2/22/23 19:19, yangerkun wrote: > > > @@ -1924,6 +1926,10 @@ static int dmcrypt_write(void *data) > > >   BUG_ON(rb_parent(write_tree.rb_node)); > > > +    if (time_is_before_ji

Re: [dm-devel] dm-crypt: fix softlockup in dmcrypt_write

2023-02-27 Thread Mike Snitzer
On Mon, Feb 27 2023 at 12:55P -0500, Mike Snitzer wrote: > On Sun, Feb 26 2023 at 8:31P -0500, > yangerkun wrote: > > > > > > > 在 2023/2/26 10:01, Bart Van Assche 写道: > > > On 2/22/23 19:19, yangerkun wrote: > > > > @@ -1924,6 +1926,10 @@ static int dmcrypt_write(void *data) > > > >

Re: [dm-devel] dm-crypt: fix softlockup in dmcrypt_write

2023-02-27 Thread Mike Snitzer
On Mon, Feb 27 2023 at 1:03P -0500, Mike Snitzer wrote: > On Mon, Feb 27 2023 at 12:55P -0500, > Mike Snitzer wrote: > > > On Sun, Feb 26 2023 at 8:31P -0500, > > yangerkun wrote: > > > > > > > > > > > 在 2023/2/26 10:01, Bart Van Assche 写道: > > > > On 2/22/23 19:19, yangerkun wrote: > > >

Re: [dm-devel] dm-crypt: reexport sysfs of kcryptd workqueue

2023-02-27 Thread Mike Snitzer
On Wed, Feb 22 2023 at 10:18P -0500, yangerkun wrote: > From: yangerkun > > 'a2b8b2d97567 ("dm crypt: export sysfs of kcryptd workqueue")' give us > idea to set specific CPU or limit max_active crypt work. However sysfs > will report a warnning and fail 'cryptsetup refresh test' since the > rel

Re: [dm-devel] [PATCH -next RFC] block: count 'ios' and 'sectors' when io is done for bio-based device

2023-02-27 Thread Yu Kuai
Hi, friendly ping ... Thanks, Kuai 在 2023/02/23 17:12, Yu Kuai 写道: From: Yu Kuai While using iostat for raid, I observed very strange 'await' occasionally, and turns out it's due to that 'ios' and 'sectors' is counted in bdev_start_io_acct(), while 'nsecs' is counted in bdev_end_io_acct(). I

Re: [dm-devel] dm-crypt: fix softlockup in dmcrypt_write

2023-02-27 Thread yangerkun
在 2023/2/28 9:25, yangerkun 写道: 在 2023/2/28 1:55, Mike Snitzer 写道: On Sun, Feb 26 2023 at  8:31P -0500, yangerkun wrote: 在 2023/2/26 10:01, Bart Van Assche 写道: On 2/22/23 19:19, yangerkun wrote: @@ -1924,6 +1926,10 @@ static int dmcrypt_write(void *data)    BUG_ON(rb_parent(wr

Re: [dm-devel] dm-crypt: reexport sysfs of kcryptd workqueue

2023-02-27 Thread yangerkun
在 2023/2/28 4:56, Mike Snitzer 写道: On Wed, Feb 22 2023 at 10:18P -0500, yangerkun wrote: From: yangerkun 'a2b8b2d97567 ("dm crypt: export sysfs of kcryptd workqueue")' give us idea to set specific CPU or limit max_active crypt work. However sysfs will report a warnning and fail 'cryptsetup

Re: [dm-devel] dm-crypt: fix softlockup in dmcrypt_write

2023-02-27 Thread yangerkun
在 2023/2/28 1:55, Mike Snitzer 写道: On Sun, Feb 26 2023 at 8:31P -0500, yangerkun wrote: 在 2023/2/26 10:01, Bart Van Assche 写道: On 2/22/23 19:19, yangerkun wrote: @@ -1924,6 +1926,10 @@ static int dmcrypt_write(void *data)   BUG_ON(rb_parent(write_tree.rb_node)); +    if (ti

[dm-devel] [bug report] BUG: KASAN: slab-use-after-free in blkg_destroy+0x34b/0x380

2023-02-27 Thread Guangwu Zhang
Hello, Found kernel issue about dm-mod blkg_destroy, please have a look if need more info. kernel repo : https://github.com/torvalds/linux.git kernel : 6.2.0.kasan just found it once and not sure the reproducer OK ] Reached target System Reboot . [ 3810.010126] systemd-shutdown[1]: Waiting for

Re: [dm-devel] dm-crypt: fix softlockup in dmcrypt_write

2023-02-27 Thread yangerkun
在 2023/2/28 2:06, Mike Snitzer 写道: On Mon, Feb 27 2023 at 1:03P -0500, Mike Snitzer wrote: On Mon, Feb 27 2023 at 12:55P -0500, Mike Snitzer wrote: On Sun, Feb 26 2023 at 8:31P -0500, yangerkun wrote: 在 2023/2/26 10:01, Bart Van Assche 写道: On 2/22/23 19:19, yangerkun wrote: @@ -1