[dm-devel] [dm] Planning to WARN_ON() when flush_scheduled_work() is used.

Hello. Like commit c4f135d64382 ("workqueue: Wrap flush_workqueue() using a macro") says, flush_scheduled_work() is dangerous and will be forbidden. But I haven't heard from you after https://lkml.kernel.org/r/ytf45omchmkxj...@redhat.com . https://lkml.kernel.org/r/49925af7-78a8-a3dd-bce6-cfc0

[dm-devel] RAID4 with no striping mode request

hi DM and Linux-RAID, There have been multiple proprietary solutions (some nearly 20 years old now) with a number of (userspace) bugs that are becoming untenable for me as an end user. Basically how they work is a closed MD module (typically administered through DM) that uses RAID4 for a dedicated

Re: [dm-devel] RAID4 with no striping mode request

> "Kyle" == Kyle Sanderson writes: > hi DM and Linux-RAID, > There have been multiple proprietary solutions (some nearly 20 years > old now) with a number of (userspace) bugs that are becoming untenable > for me as an end user. Basically how they work is a closed MD module > (typically admini

[dm-devel] "dm: prefer kmap_local_page() instead of deprecated kmap_atomic()" is broken

Hi Mike and Heinz, The following commit in linux-next is causing "BUG: scheduling while atomic" bugs. Probably because it is still using kunmap_atomic(), not kunmap_local(). commit 621d8807771e430b44136e48dfe3c53540c9953d Author: Heinz Mauelshagen Date: Tue Feb 7 20:22

Re: [dm-devel] "dm: prefer kmap_local_page() instead of deprecated kmap_atomic()" is broken

On Mon, Feb 13 2023 at 2:50P -0500, Eric Biggers wrote: > Hi Mike and Heinz, > > The following commit in linux-next is causing "BUG: scheduling while atomic" > bugs. Probably because it is still using kunmap_atomic(), not kunmap_local(). > > commit 621d8807771e430b44136e48dfe3c53540c995

[dm-devel] [PATCH 00/39] dm: fix checkpatch errors and warnings

Heinz Mauelshagen (39): dm: add missing SPDX-License-Indentifiers dm: prefer kmap_local_page() instead of deprecated kmap_atomic() dm: use fsleep() instead of msleep() for deterministic sleep duration dm: change "unsigned" to "unsigned int" dm: avoid assignment in if conditions dm: encl

[dm-devel] [PATCH 01/39] dm: add missing SPDX-License-Indentifiers

From: Heinz Mauelshagen Signed-off-by: Heinz Mauelshagen Signed-off-by: Mike Snitzer --- drivers/md/dm-bio-prison-v1.c| 1 + drivers/md/dm-bio-prison-v1.h| 1 + drivers/md/dm-bio-prison-v2.c| 1 + drivers/md/dm

[dm-devel] [PATCH 02/39] dm: prefer kmap_local_page() instead of deprecated kmap_atomic()

From: Heinz Mauelshagen Signed-off-by: Heinz Mauelshagen Signed-off-by: Mike Snitzer --- drivers/md/dm-crypt.c | 24 drivers/md/dm-log-writes.c | 12 ++-- 2 files changed, 18 insertions(+), 18 deletions(-) diff --git a/drivers/md/dm-crypt.c b/drivers/md/d

[dm-devel] [PATCH 03/39] dm: use fsleep() instead of msleep() for deterministic sleep duration

From: Heinz Mauelshagen Signed-off-by: Heinz Mauelshagen Signed-off-by: Mike Snitzer --- drivers/md/dm-init.c | 2 +- drivers/md/dm-kcopyd.c | 4 ++-- drivers/md/dm-snap.c | 6 +++--- drivers/md/dm.c| 8 4 files changed, 10 insertions(+), 10 deletions(-) diff --git a/driv

[dm-devel] [PATCH 05/39] dm: avoid assignment in if conditions

From: Heinz Mauelshagen Signed-off-by: Heinz Mauelshagen Signed-off-by: Mike Snitzer --- drivers/md/dm-crypt.c | 9 ++--- drivers/md/dm-stats.c | 3 ++- drivers/md/dm-table.c | 3 ++- drivers/md/dm-writecache.c | 11 +++ 4 files changed, 17 insertions(+), 9 deleti

[dm-devel] [PATCH 06/39] dm: enclose complex macros into parentheses where possible

From: Heinz Mauelshagen Signed-off-by: Heinz Mauelshagen Signed-off-by: Mike Snitzer --- drivers/md/dm-log.c | 6 -- include/linux/device-mapper.h | 3 +-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/md/dm-log.c b/drivers/md/dm-log.c index 955767de369b.

[dm-devel] [PATCH 07/39] dm: avoid initializing static variables

From: Heinz Mauelshagen Signed-off-by: Heinz Mauelshagen Signed-off-by: Mike Snitzer --- drivers/md/dm-bufio.c | 2 +- drivers/md/dm-crypt.c | 2 +- drivers/md/dm-raid.c | 2 +- drivers/md/dm.c | 4 ++-- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/md/dm-bufio.

[dm-devel] [PATCH 08/39] dm: address space issues relative to switch/while/for/...

From: Heinz Mauelshagen Signed-off-by: Heinz Mauelshagen Signed-off-by: Mike Snitzer --- drivers/md/dm-bio-prison-v2.c | 2 +- drivers/md/dm-cache-metadata.c | 8 drivers/md/dm-log.c| 4 ++-- drivers/md/dm-mpath.c | 2 +- drivers/md/dm-ps-io-affinity.c | 2 +- dr

[dm-devel] [PATCH 09/39] dm: address indent/space issues

From: Heinz Mauelshagen Signed-off-by: Heinz Mauelshagen Signed-off-by: Mike Snitzer --- drivers/md/dm-cache-policy.h | 2 +- drivers/md/dm-crypt.c| 2 +- drivers/md/dm-integrity.c| 5 ++--- drivers/md/dm-log.c

[dm-devel] [PATCH 11/39] dm: fix undue/missing spaces

From: Heinz Mauelshagen Signed-off-by: Heinz Mauelshagen Signed-off-by: Mike Snitzer --- drivers/md/dm-ioctl.c | 4 ++-- drivers/md/dm-mpath.c | 2 +- drivers/md/dm-ps-service-time.c | 3 +-- drivers/md/dm-snap.c| 6 +++--- drivers/md/dm-table.c | 2 +-

[dm-devel] [PATCH 10/39] dm: correct block comments format.

From: Heinz Mauelshagen Signed-off-by: Heinz Mauelshagen Signed-off-by: Mike Snitzer --- drivers/md/dm-bufio.c | 30 ++ drivers/md/dm-cache-metadata.c| 7 ++- drivers/md/dm-cache-target.c | 58 --- drivers/md/dm-

[dm-devel] [PATCH 13/39] dm crypt: correct 'foo*' to 'foo *'

From: Heinz Mauelshagen Signed-off-by: Heinz Mauelshagen Signed-off-by: Mike Snitzer --- drivers/md/dm-crypt.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/md/dm-crypt.c b/drivers/md/dm-crypt.c index 2af24a6ad81a..168f49e20beb 100644 --- a/driv

[dm-devel] [PATCH 14/39] dm block-manager: avoid not required parentheses

From: Heinz Mauelshagen Signed-off-by: Heinz Mauelshagen Signed-off-by: Mike Snitzer --- drivers/md/persistent-data/dm-block-manager.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/md/persistent-data/dm-block-manager.c b/drivers/md/persistent-data/dm-block-manage

[dm-devel] [PATCH 12/39] dm: fix trailing statements

From: Heinz Mauelshagen Signed-off-by: Heinz Mauelshagen Signed-off-by: Mike Snitzer --- drivers/md/dm-flakey.c | 3 +- drivers/md/dm-integrity.c | 54 + drivers/md/dm-io.c | 26 drivers/md/dm-snap-persistent.c | 20

[dm-devel] [PATCH 15/39] dm: avoid spaces before function arguments or in favour of tabs

From: Heinz Mauelshagen Signed-off-by: Heinz Mauelshagen Signed-off-by: Mike Snitzer --- drivers/md/dm-bio-prison-v1.c | 6 ++-- drivers/md/dm-cache-target.c| 12 drivers/md/dm-ebs-target.c | 2 +- drivers/md/dm-exception-store.h | 44 ++-- drivers

[dm-devel] [PATCH 16/39] dm: add argument identifier names

From: Heinz Mauelshagen Signed-off-by: Heinz Mauelshagen Signed-off-by: Mike Snitzer --- drivers/md/dm-bufio.c | 6 +++--- drivers/md/dm-core.h| 2 +- drivers/md/dm-era-target.c | 10 +- drivers/md/dm-snap-persistent.c | 2 +- drivers/md/dm-sysfs.c

[dm-devel] [PATCH 19/39] dm: avoid split of quoted strings where possible

From: Heinz Mauelshagen Signed-off-by: Heinz Mauelshagen Signed-off-by: Mike Snitzer --- drivers/md/dm-crypt.c | 3 +-- drivers/md/dm-ioctl.c | 6 ++ drivers/md/dm-log-userspace-transfer.c | 5 ++--- drivers/md/dm-log.c| 3 +-- driv

[dm-devel] [PATCH 17/39] dm: add missing empty lines

From: Heinz Mauelshagen Signed-off-by: Heinz Mauelshagen Signed-off-by: Mike Snitzer --- drivers/md/dm-bufio.c | 9 +++ drivers/md/dm-cache-metadata.c| 6 ++ drivers/md/dm-cache-policy-internal.h | 3 + drivers/md/dm-cache-policy-smq.c

[dm-devel] [PATCH 21/39] dm: prefer '"%s...", __func__'

From: Heinz Mauelshagen Signed-off-by: Heinz Mauelshagen Signed-off-by: Mike Snitzer --- drivers/md/dm-cache-metadata.c | 12 ++-- drivers/md/dm-era-target.c | 12 ++-- drivers/md/dm-integrity.c| 4 ++-- drivers/m

[dm-devel] [PATCH 20/39] dm: adjust EXPORT_SYMBOL() to follow functions immediately

From: Heinz Mauelshagen Signed-off-by: Heinz Mauelshagen Signed-off-by: Mike Snitzer --- drivers/md/dm-builtin.c | 1 - drivers/md/dm-path-selector.c | 3 +-- drivers/md/dm-target.c| 5 ++--- drivers/md/persistent-data/dm-btree.c | 1 - 4 files changed, 3

[dm-devel] [PATCH 26/39] dm: add missing blank line after declarations/fix those

From: Heinz Mauelshagen Signed-off-by: Heinz Mauelshagen Signed-off-by: Mike Snitzer --- drivers/md/dm-raid.c | 2 +- drivers/md/dm.c | 5 + drivers/md/persistent-data/dm-array.c | 4 ++-- drivers/md/persistent-data/dm-btree.c | 4 ++-- drivers/md/per

[dm-devel] [PATCH 27/39] dm: avoid inline filenames

From: Heinz Mauelshagen Signed-off-by: Heinz Mauelshagen Signed-off-by: Mike Snitzer --- drivers/md/dm-ima.c | 3 +-- drivers/md/dm-ima.h | 3 +-- drivers/md/dm-init.c | 1 - 3 files changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/md/dm-ima.c b/drivers/md/dm-ima.c index a1bd7c

[dm-devel] [PATCH 18/39] dm: remove unnecessary braces from single statement blocks

From: Heinz Mauelshagen Signed-off-by: Heinz Mauelshagen Signed-off-by: Mike Snitzer --- drivers/md/dm-integrity.c | 48 --- drivers/md/dm-stats.c | 9 ++-- drivers/md/dm-stripe.c| 10 ++-- drivers/md/dm-thin-

[dm-devel] [PATCH 24/39] dm: favour __packed versus "__attribute__ ((packed))"

From: Heinz Mauelshagen Signed-off-by: Heinz Mauelshagen Signed-off-by: Mike Snitzer --- drivers/md/persistent-data/dm-btree-internal.h | 4 ++-- drivers/md/persistent-data/dm-space-map-common.h | 8 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/md/persisten

[dm-devel] [PATCH 25/39] dm: avoid useless 'else' after 'break' or return'

From: Heinz Mauelshagen Signed-off-by: Heinz Mauelshagen Signed-off-by: Mike Snitzer --- drivers/md/dm-stripe.c| 8 ++--- drivers/md/dm-thin-metadata.c | 4 +-- drivers/md/dm-verity-target.c | 33 ++- drivers/md/dm-write

[dm-devel] [PATCH 29/39] dm ioctl: have constant on the right side of the test

From: Heinz Mauelshagen Signed-off-by: Heinz Mauelshagen Signed-off-by: Mike Snitzer --- drivers/md/dm-ioctl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/md/dm-ioctl.c b/drivers/md/dm-ioctl.c index ec278675a8ca..e1eddb91cc2b 100644 --- a/drivers/md/dm-ioctl

[dm-devel] [PATCH 28/39] dm: don't indent labels

From: Heinz Mauelshagen Signed-off-by: Heinz Mauelshagen Signed-off-by: Mike Snitzer --- drivers/md/dm-bio-prison-v1.c | 2 +- drivers/md/dm-io.c | 2 +- drivers/md/dm-linear.c | 2 +- drivers/md/dm-zoned-metadata.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-)

[dm-devel] [PATCH 34/39] dm integrity: change macros min/max() -> min_t/max_t where appropriate

From: Heinz Mauelshagen Signed-off-by: Heinz Mauelshagen Signed-off-by: Mike Snitzer --- drivers/md/dm-integrity.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/md/dm-integrity.c b/drivers/md/dm-integrity.c index b70defcdd982..16aa68988363 100644 --- a/

[dm-devel] [PATCH 35/39] dm: avoid void function return statements

From: Heinz Mauelshagen Signed-off-by: Heinz Mauelshagen Signed-off-by: Mike Snitzer --- drivers/md/dm-io-rewind.c | 2 -- drivers/md/dm-log-userspace-base.c | 8 drivers/md/dm-zoned-target.c | 1 - 3 files changed, 11 deletions(-) diff --git a/drivers/md/dm-io-rewind.

[dm-devel] [PATCH 22/39] dm: avoid using symbolic permissions

From: Heinz Mauelshagen Signed-off-by: Heinz Mauelshagen Signed-off-by: Mike Snitzer --- drivers/md/dm-bufio.c | 16 drivers/md/dm-kcopyd.c| 2 +- drivers/md/dm-mpath.c | 3 +-- drivers/md/dm-rq.c| 8 drivers/md/dm-stats.c

[dm-devel] [PATCH 33/39] dm: fix use of sizeof() macro

From: Heinz Mauelshagen Signed-off-by: Heinz Mauelshagen Signed-off-by: Mike Snitzer --- drivers/md/dm-bufio.c | 6 +++--- drivers/md/dm-integrity.c | 16 drivers/md/dm-kcopyd.c | 2 +- drivers/md/dm-writecache.c | 6 +++--- 4 files changed, 15 insertions(+), 15 d

[dm-devel] [PATCH 31/39] dm log: avoid multiple line dereference

From: Heinz Mauelshagen Signed-off-by: Heinz Mauelshagen Signed-off-by: Mike Snitzer --- drivers/md/dm-log.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/md/dm-log.c b/drivers/md/dm-log.c index 94c5d8a19231..5f8c9c246a7e 100644 --- a/drivers/md/dm-log.c +++ b/d

[dm-devel] [PATCH 23/39] dm: favour __aligned(N) versus "__attribute__ (aligned(N))"

From: Heinz Mauelshagen Signed-off-by: Heinz Mauelshagen Signed-off-by: Mike Snitzer --- drivers/md/dm-io.c | 2 +- drivers/md/persistent-data/dm-btree-internal.h | 4 ++-- drivers/md/persistent-data/dm-space-map-common.h | 8 3 files changed, 7 inserti

[dm-devel] [PATCH 30/39] dm log: avoid trailing semicolon in macro

From: Heinz Mauelshagen Signed-off-by: Heinz Mauelshagen Signed-off-by: Mike Snitzer --- drivers/md/dm-log.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/md/dm-log.c b/drivers/md/dm-log.c index f1bc14b6fd7c..94c5d8a19231 100644 --- a/drivers/md/dm-log.c +++ b/dri

[dm-devel] [PATCH 37/39] dm: fix suspect indent whitespace

From: Heinz Mauelshagen Signed-off-by: Heinz Mauelshagen Signed-off-by: Mike Snitzer --- drivers/md/dm-cache-target.c | 2 +- drivers/md/dm-raid.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/md/dm-cache-target.c b/drivers/md/dm-cache-target.c index a4

[dm-devel] [PATCH 32/39] dm: avoid 'do {} while(0)' loop in single statement macros

From: Heinz Mauelshagen Signed-off-by: Heinz Mauelshagen Signed-off-by: Mike Snitzer --- drivers/md/dm-integrity.c | 4 ++-- drivers/md/dm-mpath.c | 4 +--- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/md/dm-integrity.c b/drivers/md/dm-integrity.c index 4729e641bf

[dm-devel] [PATCH 38/39] dm: declare variables static when sensible

From: Heinz Mauelshagen Signed-off-by: Heinz Mauelshagen Signed-off-by: Mike Snitzer --- drivers/md/dm-cache-target.c | 2 +- drivers/md/dm-thin.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/md/dm-cache-target.c b/drivers/md/dm-cache-target.c index 74

[dm-devel] [PATCH 39/39] dm clone: prefer kvmalloc_array()

From: Heinz Mauelshagen Signed-off-by: Heinz Mauelshagen Signed-off-by: Mike Snitzer --- drivers/md/dm-clone-target.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/md/dm-clone-target.c b/drivers/md/dm-clone-target.c index 29e0b85eeaf0..f38a27604c7a 100644 --- a/dr

[dm-devel] [PATCH 36/39] dm ioctl: prefer strscpy() instead of strlcpy()

From: Heinz Mauelshagen Signed-off-by: Heinz Mauelshagen Signed-off-by: Mike Snitzer --- drivers/md/dm-ioctl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/md/dm-ioctl.c b/drivers/md/dm-ioctl.c index e1eddb91cc2b..1fed9a9719f6 100644 --- a/drivers/md/dm-ioctl

[dm-devel] [PATCH] dm sysfs: make kobj_type structure constant

Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.") the driver core allows the usage of const struct kobj_type. Take advantage of this to constify the structure definition to prevent modification at runtime. Signed-off-by: Thomas Weißschuh --- drivers/md/dm-sysfs.c | 2 +- 1 fil

Re: [dm-devel] RAID4 with no striping mode request

> On Mon, Feb 13, 2023 at 11:40 AM John Stoffel wrote: > > > "Kyle" == Kyle Sanderson writes: > > > hi DM and Linux-RAID, > > There have been multiple proprietary solutions (some nearly 20 years > > old now) with a number of (userspace) bugs that are becoming untenable > > for me as an end us