[dm-devel] [PATCH] md: dm-ioctl: drop always-false condition

2023-01-18 Thread Sergey Shtylyov
The expression 'indata[3] > ULONG_MAX' always evaluates to false since indata[] is declared as an array of *unsigned long* elements and #define ULONG_MAX represents the max value of that exact type... Note that gcc seems to be able to detect the dead code here and eliminate this check anyway... F

Re: [dm-devel] Virtio-blk extended lifetime feature

2023-01-18 Thread Enrico Granata
Hi, I am going to add +Jahdiel Alvarez who is also looking into a similar issue, and also I would like to hear thoughts of people who may have worked with (embedded or otherwise) storage more recently than I have One thought that Jahdiel and myself were pondering is whether we need "type_a" and "t

Re: [dm-devel] [PATCH rcu v2 06/20] drivers/md: Remove "select SRCU"

2023-01-18 Thread Paul E. McKenney
On Tue, Jan 17, 2023 at 06:08:46PM -0500, Mike Snitzer wrote: > On Thu, Jan 12 2023 at 7:11P -0500, > Paul E. McKenney wrote: > > > Now that the SRCU Kconfig option is unconditionally selected, there is > > no longer any point in selecting it. Therefore, remove the "select SRCU" > > Kconfig sta

Re: [dm-devel] [PATCH] md: dm-ioctl: drop always-false condition

2023-01-18 Thread Mikulas Patocka
On Tue, 17 Jan 2023, Sergey Shtylyov wrote: > The expression 'indata[3] > ULONG_MAX' always evaluates to false since > indata[] is declared as an array of *unsigned long* elements and #define > ULONG_MAX represents the max value of that exact type... > > Note that gcc seems to be able to detec

[dm-devel] [PATCH 1/2] dm era: allocate in-core writesets when loading metadata

2023-01-18 Thread Nikos Tsironis
Until now, the allocation of the in-core bitmaps was done in pre-resume by metadata_resize(). In preparation for the next commit, which makes it possible for a metadata operation, e.g. an era rollover, to run before pre-resume runs, allocate the in-core bitmaps as part of opening the metadata. Al

[dm-devel] [PATCH 2/2] dm era: avoid deadlock when swapping table

2023-01-18 Thread Nikos Tsironis
Under certain conditions, swapping a table, that includes a dm-era target, with a new table, causes a deadlock. This happens when a status (STATUSTYPE_INFO) or message IOCTL is blocked in the suspended dm-era target. dm-era executes all metadata operations in a worker thread, which stops processi

[dm-devel] [PATCH 0/2] dm era: avoid deadlock when swapping table with dm-era target

2023-01-18 Thread Nikos Tsironis
Under certain conditions, swapping a table, that includes a dm-era target, with a new table, causes a deadlock. This happens when a status (STATUSTYPE_INFO) or message IOCTL is blocked in the suspended dm-era target. dm-era executes all metadata operations in a worker thread, which stops processi

Re: [dm-devel] [PATCH] dm: remove unnecessary check when using dm_get_mdptr()

2023-01-18 Thread Hou Tao
ping ? On 12/16/2022 12:23 PM, Hou Tao wrote: > From: Hou Tao > > __hash_remove() removes hash_cell with _hash_lock locked, so acquiring > _hash_lock can guarantee no-NULL hc returned from dm_get_mdptr() must > have not been removed and hc->md must still be md. > > __hash_remove() also acquires d

Re: [dm-devel] [PATCH 0/2] dm era: avoid deadlock when swapping table with dm-era target

2023-01-18 Thread Mike Snitzer
On Wed, Jan 18 2023 at 7:29P -0500, Nikos Tsironis wrote: > Under certain conditions, swapping a table, that includes a dm-era > target, with a new table, causes a deadlock. > > This happens when a status (STATUSTYPE_INFO) or message IOCTL is blocked > in the suspended dm-era target. > > dm-er

Re: [dm-devel] Virtio-blk extended lifetime feature

2023-01-18 Thread Chaitanya Kulkarni
On 1/17/23 14:30, Enrico Granata wrote: > Hi, > I am going to add +Jahdiel Alvarez who is also looking into a similar > issue, and also I would like to hear thoughts of people who may have > worked with (embedded or otherwise) storage more recently than I have > > One thought that Jahdiel and myse

Re: [dm-devel] [LSF/MM/BPF ATTEND][LSF/MM/BPF TOPIC] : blktests: status, an expansion plan for the storage stack test framework

2023-01-18 Thread Shinichiro Kawasaki
CC+: Mike, dm-devel, Hi Chaitanya, thanks for bringing this up! I definitely want to join and learn from the discussions. Here I note my comments about them. On Jan 18, 2023 / 23:52, Chaitanya Kulkarni wrote: [...] > For storage track, I would like to propose a session dedicated to > blktests. It