[dm-devel] [next-20210827][ppc][multipathd] INFO: task hung in dm_table_add_target

2021-09-02 Thread Abdul Haleem
Greeting's multiple task hung while adding the vfc disk back to the multipath on my powerpc box running linux-next kernel Test: $ multipathd -k"remove path sde" $ multipathd -k"add path sde" After above command multipathd task hung with continuous call traces on console, it requires reboot t

[dm-devel] [PATCH v2 1/6] multipath.conf: fix typo in ghost_delay description

2021-09-02 Thread Benjamin Marzinski
Reviewed-by: Martin Wilck Signed-off-by: Benjamin Marzinski --- multipath/multipath.conf.5 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/multipath/multipath.conf.5 b/multipath/multipath.conf.5 index 064e4826..d6b8c7f6 100644 --- a/multipath/multipath.conf.5 +++ b/multipath/

[dm-devel] [PATCH v2 2/6] mpathpersist: fail commands when no usable paths exist

2021-09-02 Thread Benjamin Marzinski
"mpathpersist -oCK " will return success if it is run on devices with no usable paths, but nothing is actually done. The -L command will fail, but it should give up sooner, and with a more helpful error message. Reviewed-by: Martin Wilck Signed-off-by: Benjamin Marzinski --- libmpathpersist/mp

[dm-devel] [PATCH v2 3/6] multipath: print warning if multipathd is not running.

2021-09-02 Thread Benjamin Marzinski
If multipath notices that multipath devices exist or were created, and multipathd is not running, it now prints a warning message, so users are notified of the issue. Signed-off-by: Benjamin Marzinski --- libmultipath/configure.c | 3 ++- libmultipath/configure.h | 1 + libmu

[dm-devel] [PATCH v2 5/6] libmultipath: deal with dynamic PTHREAD_STACK_MIN

2021-09-02 Thread Benjamin Marzinski
Starting in glibc-2.34 (commit 5d98a7da), PTHREAD_STACK_MIN is defined as sysconf(_SC_THREAD_STACK_MIN) if _GNU_SOURCE is defined. sysconf() returns a long and can, at least in theory, return -1. This change causes compilation to fail in setup_thread_attr() due to a comparision with different sign

[dm-devel] [PATCH v2 0/6] Mulitpath: miscellaneous patches

2021-09-02 Thread Benjamin Marzinski
Here are a couple of unconnected patches. They (at least libmultipath.version) are meant to be applied on top of Martin's recent patchset. Changes from v1: 3/6: Reworked this to keep the logic in multipath, and prefix the output with "Warning" as suggested by Martin Wilck. 6/6: New patch to

[dm-devel] [PATCH v2 4/6] libmultipath: remove unneeded code in coalesce_paths

2021-09-02 Thread Benjamin Marzinski
The code at the end of coalesce_paths() removes a multipath device that was just created/reloaded, if none of its path devices have pp->dev set. This code is very old, and no longer has any actual effect. Multipath devices no longer get placed in pathvec without having pp->dev set. Even if they cou

[dm-devel] [PATCH v2 6/6] libmultipath: drop unnecessary parameter from remove_map()

2021-09-02 Thread Benjamin Marzinski
When remove_map() is called, if the multipath device is in a mpvec, it must be removed from it, because the device will be freed. Now that the mpvec is passed as a separate parameter to remove_map(), the purge_vec parameter is redundant. It was only used by coalesce_paths(), since the multipath de