Re: [dm-devel] dm crypt: initialize tasklet in crypt_io_init()

2023-03-09 Thread Ignat Korchagin
On Wed, Mar 8, 2023 at 8:27 PM Mike Snitzer wrote: > > On Wed, Mar 08 2023 at 2:19P -0500, > Mike Snitzer wrote: > > > On Wed, Mar 08 2023 at 8:55P -0500, > > Ignat Korchagin wrote: > > > > > Perhaps instead we can just pass an additional flag from > > > tasklet_schedule to indicate to the fun

Re: [dm-devel] dm crypt: initialize tasklet in crypt_io_init()

2023-03-09 Thread Ignat Korchagin
On Wed, Mar 8, 2023 at 7:19 PM Mike Snitzer wrote: > > On Wed, Mar 08 2023 at 8:55P -0500, > Ignat Korchagin wrote: > > > On Wed, Mar 8, 2023 at 2:56 AM Hou Tao wrote: > > > > > > Hi, > > > > > > On 3/7/2023 10:47 PM, Mike Snitzer wrote: > > > > On Mon, Mar 06 2023 at 9:12P -0500, > > > > Hou

Re: [dm-devel] dm crypt: initialize tasklet in crypt_io_init()

2023-03-08 Thread Mike Snitzer
On Wed, Mar 08 2023 at 2:19P -0500, Mike Snitzer wrote: > On Wed, Mar 08 2023 at 8:55P -0500, > Ignat Korchagin wrote: > > > Perhaps instead we can just pass an additional flag from > > tasklet_schedule to indicate to the function that we're running in a > > tasklet. I originally have chosen

Re: [dm-devel] dm crypt: initialize tasklet in crypt_io_init()

2023-03-08 Thread Mike Snitzer
On Wed, Mar 08 2023 at 8:55P -0500, Ignat Korchagin wrote: > On Wed, Mar 8, 2023 at 2:56 AM Hou Tao wrote: > > > > Hi, > > > > On 3/7/2023 10:47 PM, Mike Snitzer wrote: > > > On Mon, Mar 06 2023 at 9:12P -0500, > > > Hou Tao wrote: > > > > > >> Hi, > > >> > > >> On 3/7/2023 3:31 AM, Mike Snit

Re: [dm-devel] dm crypt: initialize tasklet in crypt_io_init()

2023-03-08 Thread Ignat Korchagin
On Wed, Mar 8, 2023 at 2:56 AM Hou Tao wrote: > > Hi, > > On 3/7/2023 10:47 PM, Mike Snitzer wrote: > > On Mon, Mar 06 2023 at 9:12P -0500, > > Hou Tao wrote: > > > >> Hi, > >> > >> On 3/7/2023 3:31 AM, Mike Snitzer wrote: > >>> On Mon, Mar 06 2023 at 8:49P -0500, > >>> Hou Tao wrote: > >>> >

Re: [dm-devel] dm crypt: initialize tasklet in crypt_io_init()

2023-03-07 Thread Hou Tao
Hi, On 3/7/2023 10:47 PM, Mike Snitzer wrote: > On Mon, Mar 06 2023 at 9:12P -0500, > Hou Tao wrote: > >> Hi, >> >> On 3/7/2023 3:31 AM, Mike Snitzer wrote: >>> On Mon, Mar 06 2023 at 8:49P -0500, >>> Hou Tao wrote: >>> From: Hou Tao When neither no_read_workqueue nor no_write_

Re: [dm-devel] dm crypt: initialize tasklet in crypt_io_init()

2023-03-07 Thread Mike Snitzer
On Mon, Mar 06 2023 at 9:12P -0500, Hou Tao wrote: > Hi, > > On 3/7/2023 3:31 AM, Mike Snitzer wrote: > > On Mon, Mar 06 2023 at 8:49P -0500, > > Hou Tao wrote: > > > >> From: Hou Tao > >> > >> When neither no_read_workqueue nor no_write_workqueue are enabled, > >> tasklet_trylock() in crypt

Re: [dm-devel] dm crypt: initialize tasklet in crypt_io_init()

2023-03-06 Thread Hou Tao
Hi, On 3/7/2023 3:31 AM, Mike Snitzer wrote: > On Mon, Mar 06 2023 at 8:49P -0500, > Hou Tao wrote: > >> From: Hou Tao >> >> When neither no_read_workqueue nor no_write_workqueue are enabled, >> tasklet_trylock() in crypt_dec_pending() may still return false due to >> an uninitialized state, an

Re: [dm-devel] dm crypt: initialize tasklet in crypt_io_init()

2023-03-06 Thread Mike Snitzer
On Mon, Mar 06 2023 at 8:49P -0500, Hou Tao wrote: > From: Hou Tao > > When neither no_read_workqueue nor no_write_workqueue are enabled, > tasklet_trylock() in crypt_dec_pending() may still return false due to > an uninitialized state, and dm-crypt will do io completion in io_queue > instead