Re: [dm-devel] dm-raid: stack limits instead of overwriting them.

2020-12-17 Thread S. Baerwolf
Hi I just saw your posts right now. (After posting my text "[PATCH] dm-raid: set discard_granularity non-zero if possible" yesterday) How about iterating over all meta-devices corresponding to the raid1? Having mixed technology devices (TRIM and nonTRIM) I assume discard should be switched of

Re: [dm-devel] dm-raid: stack limits instead of overwriting them.

2020-09-25 Thread Mike Snitzer
On Fri, Sep 25 2020 at 8:04am -0400, Mikulas Patocka wrote: > > > On Thu, 24 Sep 2020, Mike Snitzer wrote: > > > On Thu, Sep 24 2020 at 2:12pm -0400, > > Mikulas Patocka wrote: > > > > > > > > > > > On Thu, 24 Sep 2020, Mikulas Patocka wrote: > > > > > > > > > > > > > > > On Thu, 24 S

Re: [dm-devel] dm-raid: stack limits instead of overwriting them.

2020-09-25 Thread Mikulas Patocka
On Thu, 24 Sep 2020, Mike Snitzer wrote: > On Thu, Sep 24 2020 at 2:12pm -0400, > Mikulas Patocka wrote: > > > > > > > On Thu, 24 Sep 2020, Mikulas Patocka wrote: > > > > > > > > > > > On Thu, 24 Sep 2020, Mike Snitzer wrote: > > > > > > > WAIT... Could it be that raid_io_hints _really

Re: [dm-devel] dm-raid: stack limits instead of overwriting them.

2020-09-24 Thread Mike Snitzer
On Thu, Sep 24 2020 at 2:56pm -0400, John Dorminy wrote: > On Thu, Sep 24, 2020 at 1:24 PM John Dorminy wrote: > > > > I am impressed at how much I read wrong... > > > > On Thu, Sep 24, 2020 at 1:00 PM Mike Snitzer wrote: > > > > > > On Thu, Sep 24 2020 at 12:45pm -0400, > > > John Dorminy wr

Re: [dm-devel] dm-raid: stack limits instead of overwriting them.

2020-09-24 Thread Mike Snitzer
On Thu, Sep 24 2020 at 2:12pm -0400, Mikulas Patocka wrote: > > > On Thu, 24 Sep 2020, Mikulas Patocka wrote: > > > > > > > On Thu, 24 Sep 2020, Mike Snitzer wrote: > > > > > WAIT... Could it be that raid_io_hints _really_ meant to special case > > > raid0 and raid10 -- due to their stripi

Re: [dm-devel] dm-raid: stack limits instead of overwriting them.

2020-09-24 Thread John Dorminy
On Thu, Sep 24, 2020 at 1:24 PM John Dorminy wrote: > > I am impressed at how much I read wrong... > > On Thu, Sep 24, 2020 at 1:00 PM Mike Snitzer wrote: > > > > On Thu, Sep 24 2020 at 12:45pm -0400, > > John Dorminy wrote: > > > > > I don't understand how this works... > > > > > > Can chunk_si

Re: [dm-devel] dm-raid: stack limits instead of overwriting them.

2020-09-24 Thread Mikulas Patocka
On Thu, 24 Sep 2020, Mikulas Patocka wrote: > > > On Thu, 24 Sep 2020, Mike Snitzer wrote: > > > WAIT... Could it be that raid_io_hints _really_ meant to special case > > raid0 and raid10 -- due to their striping/splitting requirements!? > > So, not raid1 but raid0? > > > > E.g.: > > > > d

Re: [dm-devel] dm-raid: stack limits instead of overwriting them.

2020-09-24 Thread John Dorminy
I am impressed at how much I read wrong... On Thu, Sep 24, 2020 at 1:00 PM Mike Snitzer wrote: > > On Thu, Sep 24 2020 at 12:45pm -0400, > John Dorminy wrote: > > > I don't understand how this works... > > > > Can chunk_size_bytes be 0? If not, how is discard_granularity being set to > > 0? > >

Re: [dm-devel] dm-raid: stack limits instead of overwriting them.

2020-09-24 Thread Mikulas Patocka
On Thu, 24 Sep 2020, Mike Snitzer wrote: > WAIT... Could it be that raid_io_hints _really_ meant to special case > raid0 and raid10 -- due to their striping/splitting requirements!? > So, not raid1 but raid0? > > E.g.: > > diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c > index 56b72

Re: [dm-devel] dm-raid: stack limits instead of overwriting them.

2020-09-24 Thread Mike Snitzer
On Thu, Sep 24 2020 at 12:45pm -0400, John Dorminy wrote: > I don't understand how this works... > > Can chunk_size_bytes be 0? If not, how is discard_granularity being set to 0? Yeah, I had same question.. see the reply I just sent in this thread: https://www.redhat.com/archives/dm-devel/2020-

Re: [dm-devel] dm-raid: stack limits instead of overwriting them.

2020-09-24 Thread Mike Snitzer
On Thu, Sep 24 2020 at 12:26pm -0400, Mikulas Patocka wrote: > This patch fixes a warning WARN_ON_ONCE(!q->limits.discard_granularity). > The reason is that the function raid_io_hints overwrote > limits->discard_granularity with zero. We need to properly stack the > limits instead of overwriting