Re: [dm-devel] dm-crypt: fix softlockup in dmcrypt_write

2023-03-06 Thread Mikulas Patocka
On Mon, 6 Mar 2023, Bart Van Assche wrote: > On 3/6/23 10:02, Mikulas Patocka wrote: > > On Tue, 28 Feb 2023, yangerkun wrote: > > > It's ok to fix the softlockup, but for async write encrypt, > > > kcryptd_crypt_write_io_submit will add bio to write_tree, and once we > > > call cond_resched be

Re: [dm-devel] dm-crypt: fix softlockup in dmcrypt_write

2023-03-06 Thread Bart Van Assche
On 3/6/23 10:02, Mikulas Patocka wrote: On Tue, 28 Feb 2023, yangerkun wrote: It's ok to fix the softlockup, but for async write encrypt, kcryptd_crypt_write_io_submit will add bio to write_tree, and once we call cond_resched before every kcryptd_io_write, the write performance may be poor while

Re: [dm-devel] dm-crypt: fix softlockup in dmcrypt_write

2023-03-06 Thread Mikulas Patocka
On Tue, 28 Feb 2023, yangerkun wrote: > > > 在 2023/2/28 2:06, Mike Snitzer 写道: > > On Mon, Feb 27 2023 at 1:03P -0500, > > Mike Snitzer wrote: > > > >> On Mon, Feb 27 2023 at 12:55P -0500, > >> Mike Snitzer wrote: > >> > >>> On Sun, Feb 26 2023 at 8:31P -0500, > >>> yangerkun wrote: > >>

Re: [dm-devel] dm-crypt: fix softlockup in dmcrypt_write

2023-02-27 Thread yangerkun
在 2023/2/28 2:06, Mike Snitzer 写道: On Mon, Feb 27 2023 at 1:03P -0500, Mike Snitzer wrote: On Mon, Feb 27 2023 at 12:55P -0500, Mike Snitzer wrote: On Sun, Feb 26 2023 at 8:31P -0500, yangerkun wrote: 在 2023/2/26 10:01, Bart Van Assche 写道: On 2/22/23 19:19, yangerkun wrote: @@ -1

Re: [dm-devel] dm-crypt: fix softlockup in dmcrypt_write

2023-02-27 Thread yangerkun
在 2023/2/28 1:55, Mike Snitzer 写道: On Sun, Feb 26 2023 at 8:31P -0500, yangerkun wrote: 在 2023/2/26 10:01, Bart Van Assche 写道: On 2/22/23 19:19, yangerkun wrote: @@ -1924,6 +1926,10 @@ static int dmcrypt_write(void *data)   BUG_ON(rb_parent(write_tree.rb_node)); +    if (ti

Re: [dm-devel] dm-crypt: fix softlockup in dmcrypt_write

2023-02-27 Thread yangerkun
在 2023/2/28 9:25, yangerkun 写道: 在 2023/2/28 1:55, Mike Snitzer 写道: On Sun, Feb 26 2023 at  8:31P -0500, yangerkun wrote: 在 2023/2/26 10:01, Bart Van Assche 写道: On 2/22/23 19:19, yangerkun wrote: @@ -1924,6 +1926,10 @@ static int dmcrypt_write(void *data)    BUG_ON(rb_parent(wr

Re: [dm-devel] dm-crypt: fix softlockup in dmcrypt_write

2023-02-27 Thread Mike Snitzer
On Mon, Feb 27 2023 at 1:03P -0500, Mike Snitzer wrote: > On Mon, Feb 27 2023 at 12:55P -0500, > Mike Snitzer wrote: > > > On Sun, Feb 26 2023 at 8:31P -0500, > > yangerkun wrote: > > > > > > > > > > > 在 2023/2/26 10:01, Bart Van Assche 写道: > > > > On 2/22/23 19:19, yangerkun wrote: > > >

Re: [dm-devel] dm-crypt: fix softlockup in dmcrypt_write

2023-02-27 Thread Mike Snitzer
On Mon, Feb 27 2023 at 12:55P -0500, Mike Snitzer wrote: > On Sun, Feb 26 2023 at 8:31P -0500, > yangerkun wrote: > > > > > > > 在 2023/2/26 10:01, Bart Van Assche 写道: > > > On 2/22/23 19:19, yangerkun wrote: > > > > @@ -1924,6 +1926,10 @@ static int dmcrypt_write(void *data) > > > >

Re: [dm-devel] dm-crypt: fix softlockup in dmcrypt_write

2023-02-27 Thread Mike Snitzer
On Sun, Feb 26 2023 at 8:31P -0500, yangerkun wrote: > > > 在 2023/2/26 10:01, Bart Van Assche 写道: > > On 2/22/23 19:19, yangerkun wrote: > > > @@ -1924,6 +1926,10 @@ static int dmcrypt_write(void *data) > > >   BUG_ON(rb_parent(write_tree.rb_node)); > > > +    if (time_is_before_ji