Re: [dm-devel] [PATCH v4 10/18] nvme: Add helper to send pr command

2023-03-14 Thread Christoph Hellwig
Looks good, Reviewed-by: Christoph Hellwig althought I'd also prefer to drop the redundant else. -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH v4 10/18] nvme: Add helper to send pr command

2023-03-06 Thread Mike Christie
On 3/5/23 3:28 PM, Chaitanya Kulkarni wrote: >> >> +static int nvme_send_pr_command(struct block_device *bdev, >> +struct nvme_command *c, void *data, unsigned int data_len) >> +{ >> +if (IS_ENABLED(CONFIG_NVME_MULTIPATH) && >> +bdev->bd_disk->fops == &nvme_ns_head_ops) >

Re: [dm-devel] [PATCH v4 10/18] nvme: Add helper to send pr command

2023-03-05 Thread Chaitanya Kulkarni
On 2/24/2023 9:44 AM, Mike Christie wrote: > Move the code that checks for multipath support and sends the pr command > to a new helper so it can be used by the reservation report support added > in the next patches. > > Signed-off-by: Mike Christie > --- > drivers/nvme/host/pr.c | 23 +