Re: [dm-devel] [PATCH v2 22/37] libmultipath: sort aliases by length and strcmp

2023-09-13 Thread Benjamin Marzinski
On Wed, Sep 13, 2023 at 09:07:27PM +0200, Martin Wilck wrote: > On Wed, 2023-09-13 at 09:38 -0500, Benjamin Marzinski wrote: > > On Wed, Sep 13, 2023 at 03:53:25PM +0200, Martin Wilck wrote: > > > On Tue, 2023-09-12 at 18:00 -0500, Benjamin Marzinski wrote: > > > > On Mon, Sep 11, 2023 at 06:38:31P

Re: [dm-devel] [PATCH v2 22/37] libmultipath: sort aliases by length and strcmp

2023-09-13 Thread Martin Wilck
On Wed, 2023-09-13 at 09:38 -0500, Benjamin Marzinski wrote: > On Wed, Sep 13, 2023 at 03:53:25PM +0200, Martin Wilck wrote: > > On Tue, 2023-09-12 at 18:00 -0500, Benjamin Marzinski wrote: > > > On Mon, Sep 11, 2023 at 06:38:31PM +0200, mwi...@suse.com wrote: > > > > + */ > > > > +static int alias

Re: [dm-devel] [PATCH v2 22/37] libmultipath: sort aliases by length and strcmp

2023-09-13 Thread Benjamin Marzinski
On Wed, Sep 13, 2023 at 03:53:25PM +0200, Martin Wilck wrote: > On Tue, 2023-09-12 at 18:00 -0500, Benjamin Marzinski wrote: > > On Mon, Sep 11, 2023 at 06:38:31PM +0200, mwi...@suse.com wrote: > > > From: Martin Wilck > > > > > > The current sort order of aliases is alphabetical, which is does >

Re: [dm-devel] [PATCH v2 22/37] libmultipath: sort aliases by length and strcmp

2023-09-13 Thread Martin Wilck
On Tue, 2023-09-12 at 18:00 -0500, Benjamin Marzinski wrote: > On Mon, Sep 11, 2023 at 06:38:31PM +0200, mwi...@suse.com wrote: > > From: Martin Wilck > > > > The current sort order of aliases is alphabetical, which is does > > not match > > the actual order of aliases, where "mpathaa" > "mpathz"

Re: [dm-devel] [PATCH v2 22/37] libmultipath: sort aliases by length and strcmp

2023-09-12 Thread Benjamin Marzinski
On Mon, Sep 11, 2023 at 06:38:31PM +0200, mwi...@suse.com wrote: > From: Martin Wilck > > The current sort order of aliases is alphabetical, which is does not match > the actual order of aliases, where "mpathaa" > "mpathz". Change the ordering > as > follows: first sort by string length, then al