Re: [dm-devel] [PATCH v4 11/18] nvme: Add pr_ops read_keys support

2023-03-14 Thread Christoph Hellwig
On Fri, Feb 24, 2023 at 11:44:55AM -0600, Mike Christie wrote: > + /* > + * Assume we are using 128-bit host IDs and allocate a buffer large > + * enough to get enough keys to fill the return keys buffer. > + */ > + rs_len = sizeof(*rs) + > + num_keys * si

[dm-devel] [PATCH v4 11/18] nvme: Add pr_ops read_keys support

2023-02-26 Thread Mike Christie
This patch adds support for the pr_ops read_keys callout by calling the NVMe Reservation Report helper, then parsing that info to get the controller's registered keys. Because the callout is only used in the kernel where the callers, like LIO, do not know about controller/host IDs, the callout just