Re: [dm-devel] [PATCH v4 09/18] nvme: Move pr code to it's own file

2023-03-14 Thread Keith Busch
On Tue, Mar 14, 2023 at 06:13:22PM +0100, Christoph Hellwig wrote: > > +++ b/drivers/nvme/host/pr.c > > @@ -0,0 +1,155 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > I'd feel much more comfortable if we had a copyright notice code > here. This code was written by Keith, maybe he can help to fill

Re: [dm-devel] [PATCH v4 09/18] nvme: Move pr code to it's own file

2023-03-14 Thread Christoph Hellwig
> +++ b/drivers/nvme/host/pr.c > @@ -0,0 +1,155 @@ > +// SPDX-License-Identifier: GPL-2.0 I'd feel much more comfortable if we had a copyright notice code here. This code was written by Keith, maybe he can help to fill in what the proper notice should be? Otherwise this looks good to me. -- dm-

[dm-devel] [PATCH v4 09/18] nvme: Move pr code to it's own file

2023-02-26 Thread Mike Christie
This patch moves the pr code to it's own file because I'm going to be adding more functions and core.c is getting bigger. Signed-off-by: Mike Christie Reviewed-by: Chaitanya Kulkarni Reviewed-by: Keith Busch --- drivers/nvme/host/Makefile | 2 +- drivers/nvme/host/core.c | 148