[dm-devel] [PATCH v3 19/19] block: mark bio_add_page as __must_check

2023-04-19 Thread Johannes Thumshirn
From: Johannes Thumshirn Now that all users of bio_add_page check for the return value, mark bio_add_page as __must_check. Signed-off-by: Johannes Thumshirn Reviewed-by: Damien Le Moal --- include/linux/bio.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/bi

Re: [dm-devel] [PATCH v3 19/19] block: mark bio_add_page as __must_check

2023-04-19 Thread Johannes Thumshirn
On 19/04/2023 16:19, Matthew Wilcox wrote: On Wed, Apr 19, 2023 at 04:09:29PM +0200, Johannes Thumshirn wrote: Now that all users of bio_add_page check for the return value, mark bio_add_page as __must_check. Should probably add __must_check to bio_add_folio too? If this is really the way you

Re: [dm-devel] [PATCH v3 19/19] block: mark bio_add_page as __must_check

2023-04-19 Thread Matthew Wilcox
On Wed, Apr 19, 2023 at 04:09:29PM +0200, Johannes Thumshirn wrote: > Now that all users of bio_add_page check for the return value, mark > bio_add_page as __must_check. Should probably add __must_check to bio_add_folio too? If this is really the way you want to go ... means we also need a __bio_