Re: [dm-devel] [PATCH v3 11/19] gfs: use __bio_add_page for adding single page to bio

2023-04-20 Thread Johannes Thumshirn
On 19/04/2023 17:19, Andreas Gruenbacher wrote: On Wed, Apr 19, 2023 at 4:10 PM Johannes Thumshirn wrote: From: Johannes Thumshirn The GFS superblock reading code uses bio_add_page() to add a page to a newly created bio. bio_add_page() can fail, but the return value is never checked. It's

Re: [dm-devel] [PATCH v3 11/19] gfs: use __bio_add_page for adding single page to bio

2023-04-19 Thread Andreas Gruenbacher
On Wed, Apr 19, 2023 at 4:10 PM Johannes Thumshirn wrote: > > From: Johannes Thumshirn > > The GFS superblock reading code uses bio_add_page() to add a page to a > newly created bio. bio_add_page() can fail, but the return value is never > checked. It's GFS2, not GFS, but otherwise this is obvio

[dm-devel] [PATCH v3 11/19] gfs: use __bio_add_page for adding single page to bio

2023-04-19 Thread Johannes Thumshirn
From: Johannes Thumshirn The GFS superblock reading code uses bio_add_page() to add a page to a newly created bio. bio_add_page() can fail, but the return value is never checked. Use __bio_add_page() as adding a single page to a newly created bio is guaranteed to succeed. This brings us a step