Re: [dm-devel] [PATCH v2 4/6] device-mapper: Avoid double-fetch of version

2023-06-22 Thread Demi Marie Obenour
On Thu, Jun 22, 2023 at 12:20:40PM -0400, Mike Snitzer wrote: > On Sat, Jun 03 2023 at 10:52P -0400, > Demi Marie Obenour wrote: > > > The version is fetched once in check_version(), which then does some > > validation and then overwrites the version in userspace with the API > > version supporte

Re: [dm-devel] [PATCH v2 4/6] device-mapper: Avoid double-fetch of version

2023-06-22 Thread Mike Snitzer
On Sat, Jun 03 2023 at 10:52P -0400, Demi Marie Obenour wrote: > The version is fetched once in check_version(), which then does some > validation and then overwrites the version in userspace with the API > version supported by the kernel. copy_params() then fetches the version > from userspace

[dm-devel] [PATCH v2 4/6] device-mapper: Avoid double-fetch of version

2023-06-03 Thread Demi Marie Obenour
The version is fetched once in check_version(), which then does some validation and then overwrites the version in userspace with the API version supported by the kernel. copy_params() then fetches the version from userspace *again*, and this time no validation is done. The result is that the ker