Re: [dm-devel] [PATCH v2 17/19] md: raid1: check if adding pages to resync bio fails

2023-04-10 Thread Song Liu
On Tue, Apr 4, 2023 at 1:26 AM Johannes Thumshirn wrote: > > On 31/03/2023 20:13, Song Liu wrote: > > On Thu, Mar 30, 2023 at 3:44 AM Johannes Thumshirn > > wrote: > >> > >> Check if adding pages to resync bio fails and if bail out. > >> > >> As the comment above suggests this cannot happen, WARN

Re: [dm-devel] [PATCH v2 17/19] md: raid1: check if adding pages to resync bio fails

2023-04-04 Thread Johannes Thumshirn
On 31/03/2023 20:13, Song Liu wrote: On Thu, Mar 30, 2023 at 3:44 AM Johannes Thumshirn wrote: Check if adding pages to resync bio fails and if bail out. As the comment above suggests this cannot happen, WARN if it actually happens. This way we can mark bio_add_pages as __must_check. Signed

Re: [dm-devel] [PATCH v2 17/19] md: raid1: check if adding pages to resync bio fails

2023-04-02 Thread Song Liu
On Thu, Mar 30, 2023 at 3:44 AM Johannes Thumshirn wrote: > > Check if adding pages to resync bio fails and if bail out. > > As the comment above suggests this cannot happen, WARN if it actually > happens. > > This way we can mark bio_add_pages as __must_check. > > Signed-off-by: Johannes Thumshir

[dm-devel] [PATCH v2 17/19] md: raid1: check if adding pages to resync bio fails

2023-03-30 Thread Johannes Thumshirn
Check if adding pages to resync bio fails and if bail out. As the comment above suggests this cannot happen, WARN if it actually happens. This way we can mark bio_add_pages as __must_check. Signed-off-by: Johannes Thumshirn Reviewed-by: Damien Le Moal --- drivers/md/raid1-10.c | 7 ++- d