Re: [dm-devel] [PATCH 4/5] multipath-tools tests: add tests for group_by_tpg policy

2023-06-02 Thread Martin Wilck
On Thu, 2023-06-01 at 12:51 -0500, Benjamin Marzinski wrote: > On Wed, May 31, 2023 at 03:30:02PM +, Martin Wilck wrote: > > On Fri, 2023-05-19 at 18:02 -0500, Benjamin Marzinski wrote: > > > Signed-off-by: Benjamin Marzinski > > > > I wonder if it might make sense for group_by_tpg to mock ca

Re: [dm-devel] [PATCH 4/5] multipath-tools tests: add tests for group_by_tpg policy

2023-06-01 Thread Benjamin Marzinski
On Wed, May 31, 2023 at 03:30:02PM +, Martin Wilck wrote: > On Fri, 2023-05-19 at 18:02 -0500, Benjamin Marzinski wrote: > > Signed-off-by: Benjamin Marzinski > > I wonder if it might make sense for group_by_tpg to mock calls to > getprio (assigning the prio from the path's TPG ID) rather tha

Re: [dm-devel] [PATCH 4/5] multipath-tools tests: add tests for group_by_tpg policy

2023-05-31 Thread Martin Wilck
On Fri, 2023-05-19 at 18:02 -0500, Benjamin Marzinski wrote: > Signed-off-by: Benjamin Marzinski I wonder if it might make sense for group_by_tpg to mock calls to getprio (assigning the prio from the path's TPG ID) rather than calling set_priority() directly. > --- >  tests/pgpolicy.c | 201 > +

[dm-devel] [PATCH 4/5] multipath-tools tests: add tests for group_by_tpg policy

2023-05-19 Thread Benjamin Marzinski
Signed-off-by: Benjamin Marzinski --- tests/pgpolicy.c | 201 +++ 1 file changed, 201 insertions(+) diff --git a/tests/pgpolicy.c b/tests/pgpolicy.c index 43be831f..85fa30ce 100644 --- a/tests/pgpolicy.c +++ b/tests/pgpolicy.c @@ -32,6 +32,15 @@ struct