Re: [dm-devel] [PATCH 10/31] block: remove the unused mode argument to ->release

2023-06-07 Thread Jinpu Wang
On Tue, Jun 6, 2023 at 9:40 AM Christoph Hellwig wrote: > > The mode argument to the ->release block_device_operation is never used, > so remove it. > > Signed-off-by: Christoph Hellwig > --- > arch/um/drivers/ubd_kern.c | 4 ++-- > arch/xtensa/platforms/iss/simdisk.c | 2 +- > block/

Re: [dm-devel] [PATCH 10/31] block: remove the unused mode argument to ->release

2023-06-07 Thread Christian Brauner
On Tue, Jun 06, 2023 at 09:39:29AM +0200, Christoph Hellwig wrote: > The mode argument to the ->release block_device_operation is never used, > so remove it. > > Signed-off-by: Christoph Hellwig > --- Good cleanup. Looks good to me, Acked-by: Christian Brauner -- dm-devel mailing list dm-devel

Re: [dm-devel] [PATCH 10/31] block: remove the unused mode argument to ->release

2023-06-07 Thread Hannes Reinecke
On 6/6/23 09:39, Christoph Hellwig wrote: The mode argument to the ->release block_device_operation is never used, so remove it. Signed-off-by: Christoph Hellwig --- arch/um/drivers/ubd_kern.c | 4 ++-- arch/xtensa/platforms/iss/simdisk.c | 2 +- block/bdev.c

[dm-devel] [PATCH 10/31] block: remove the unused mode argument to ->release

2023-06-06 Thread Christoph Hellwig
The mode argument to the ->release block_device_operation is never used, so remove it. Signed-off-by: Christoph Hellwig --- arch/um/drivers/ubd_kern.c | 4 ++-- arch/xtensa/platforms/iss/simdisk.c | 2 +- block/bdev.c| 14 +++--- drivers/block/amiflop.c