[dm-devel] [PATCH 03/24] PM: hibernate: remove the global snapshot_test variable

2023-05-31 Thread Christoph Hellwig
Passing call dependent variable in global variables is a huge antipattern. Fix it up. Signed-off-by: Christoph Hellwig Acked-by: Rafael J. Wysocki --- kernel/power/hibernate.c | 17 ++--- kernel/power/power.h | 3 +-- kernel/power/swap.c | 2 +- 3 files changed, 8 insert

Re: [dm-devel] [PATCH 03/24] PM: hibernate: remove the global snapshot_test variable

2023-05-23 Thread Rafael J. Wysocki
On Tue, May 23, 2023 at 9:45 AM Christoph Hellwig wrote: > > Passing call dependent variable in global variables is a huge > antipattern. Fix it up. > > Signed-off-by: Christoph Hellwig Acked-by: Rafael J. Wysocki > --- > kernel/power/hibernate.c | 17 ++--- > kernel/power/power.

[dm-devel] [PATCH 03/24] PM: hibernate: remove the global snapshot_test variable

2023-05-23 Thread Christoph Hellwig
Passing call dependent variable in global variables is a huge antipattern. Fix it up. Signed-off-by: Christoph Hellwig --- kernel/power/hibernate.c | 17 ++--- kernel/power/power.h | 3 +-- kernel/power/swap.c | 2 +- 3 files changed, 8 insertions(+), 14 deletions(-) dif