Re: [dm-devel] [PATCH] multipathd: avoid unnecessary path read-only reloads

2021-12-14 Thread Benjamin Marzinski
On Fri, Dec 03, 2021 at 08:25:00AM +, Martin Wilck wrote: > On Thu, 2021-11-18 at 16:47 -0600, Benjamin Marzinski wrote: > > +int > > +sysfs_get_ro (struct path *pp) > > +{ > > +   int ro; > > +   char buff[3]; /* Either "0\n\0" or "1\n\0" */ > > + > > +   if (!pp->udev) > > +  

Re: [dm-devel] [PATCH] multipathd: avoid unnecessary path read-only reloads

2021-12-06 Thread Benjamin Marzinski
On Fri, Dec 03, 2021 at 08:25:00AM +, Martin Wilck wrote: > On Thu, 2021-11-18 at 16:47 -0600, Benjamin Marzinski wrote: > > A mulitpath device can only be reloaded read/write when all paths are > > read/write. Also, whenever a read-only device is rescanned, the scsi > > subsystem will first un

Re: [dm-devel] [PATCH] multipathd: avoid unnecessary path read-only reloads

2021-11-23 Thread Benjamin Marzinski
On Tue, Nov 23, 2021 at 11:05:20AM +, Martin Wilck wrote: > Hi Ben, > > some more thoughts about the ro handling. > > On Mon, 2021-11-22 at 20:39 +0100, Martin Wilck wrote: > > On Mon, 2021-11-22 at 11:43 -0600, Benjamin Marzinski wrote: > > > On Mon, Nov 22, 2021 at 04:48:06PM +, Martin

Re: [dm-devel] [PATCH] multipathd: avoid unnecessary path read-only reloads

2021-11-22 Thread Benjamin Marzinski
On Mon, Nov 22, 2021 at 04:48:06PM +, Martin Wilck wrote: > On Mon, 2021-11-22 at 09:35 -0600, Benjamin Marzinski wrote: > > On Fri, Nov 19, 2021 at 09:33:39PM +, Martin Wilck wrote: > > > On Thu, 2021-11-18 at 16:47 -0600, Benjamin Marzinski wrote: > > > > A mulitpath device can only be re

Re: [dm-devel] [PATCH] multipathd: avoid unnecessary path read-only reloads

2021-11-22 Thread Benjamin Marzinski
On Fri, Nov 19, 2021 at 09:33:39PM +, Martin Wilck wrote: > On Thu, 2021-11-18 at 16:47 -0600, Benjamin Marzinski wrote: > > A mulitpath device can only be reloaded read/write when all paths are > > read/write. Also, whenever a read-only device is rescanned, the scsi > > subsystem will first un

[dm-devel] [PATCH] multipathd: avoid unnecessary path read-only reloads

2021-11-18 Thread Benjamin Marzinski
A mulitpath device can only be reloaded read/write when all paths are read/write. Also, whenever a read-only device is rescanned, the scsi subsystem will first unconditionally issue a uevent with DISK_RO=0 before checking the read-only status, and if it the device is still read-only, issuing anothe