Re: [dm-devel] [PATCH] dm-writecache: fix a crash when unloading

2020-02-12 Thread Mikulas Patocka
On Wed, 12 Feb 2020, John Dorminy wrote: > > Also, the test "!dm_suspended(wc->ti)" in writecache_writeback is not > > sufficient, because dm_suspended returns zero while writecache_suspend is > > in progress. We add a variable wc->suspending and set it in > > writecache_suspend. Without this v

Re: [dm-devel] [PATCH] dm-writecache: fix a crash when unloading

2020-02-12 Thread John Dorminy
> Also, the test "!dm_suspended(wc->ti)" in writecache_writeback is not > sufficient, because dm_suspended returns zero while writecache_suspend is > in progress. We add a variable wc->suspending and set it in > writecache_suspend. Without this variable, drain_workqueue would spit > warnings: > wor

[dm-devel] [PATCH] dm-writecache: fix a crash when unloading

2020-02-12 Thread Mikulas Patocka
This patch fixes a crash in writecache_writeback when replacing the dm-writecache target: general protection fault: [#1] SMP PTI CPU: 28 PID: 6388 Comm: kworker/28:2 Kdump: loaded Tainted: GW - -t - 4.18.0-173.el8.x86_64 #1 Hardware name: Dell Inc. PowerEdge R830/0V