Re: [dm-devel] [RFC PATCH] dm-rq: fix double free of blk tag set in dev remove after table load fails

2021-05-01 Thread Benjamin Block
On Thu, Apr 29, 2021 at 11:37:00PM +0200, Benjamin Block wrote: > When loading a device-mapper table for a request-based mapped device, > and the allocation/initialization of the blk-mq tag set for the device > fails, a following device remove will cause a double free. > > [snip]

[dm-devel] [RFC PATCH] dm-rq: fix double free of blk tag set in dev remove after table load fails

2021-04-29 Thread Benjamin Block
Fix this by also setting the pointer to NULL in `dm_mq_init_request_queue()` after error-handling. Cc: # 4.6+ Fixes: 1c357a1e86a4 ("dm: allocate blk_mq_tag_set rather than embed in mapped_device") Signed-off-by: Benjamin Block --- drivers/md/dm-rq.c | 1 + 1 file changed, 1 insertion

Re: [dm-devel] dm-multipath - IO queue dispatch based on FPIN Congestion/Latency notifications.

2021-03-29 Thread Benjamin Block
org/linux-scsi/ca995d96-608b-39b9-8ded-4a6dd7598...@suse.de/ Not sure what happened in between, didn't see anything on the mpath topic yet. -- Best Regards, Benjamin Block / Linux on IBM Z Kernel Development / IBM Systems IBM Deutschland Research & Development GmbH/https://www.ib

Re: [dm-devel] [PATCH 2/2] multipathd: add recheck_wwid_time option to verify the path wwid

2021-02-17 Thread Benjamin Block
me the storage side.  Yeah, just for reference, I saw this happening in practice when something with the LU mapping changed on IBM storage - IIRC I saw it with capacity changes. You end up in this code in the kernel: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/dri

Re: [dm-devel] [PATCH 2/2] multipathd: add recheck_wwid_time option to verify the path wwid

2021-02-11 Thread Benjamin Block
On Wed, Feb 10, 2021 at 07:09:31PM +0100, Benjamin Block wrote: > On Tue, Feb 09, 2021 at 10:19:45PM +, Martin Wilck wrote: > > On Mon, 2021-02-08 at 23:19 -0600, Benjamin Marzinski wrote: > > > There are cases where the wwid of a path changes due to LUN remapping > &

Re: [dm-devel] [PATCH V2 0/2] block/scsi/dm-rq: fix leak of request private data in dm-mpath

2019-07-29 Thread Benjamin Block
, see the following link: > > https://lore.kernel.org/linux-block/f122e8f2-5ede-2d83-9ca0-bc713ce66...@huawei.com/T/#t > > V2: > - run .cleanup_rq() in blk_mq_free_request(), as suggested by Mike -- With Best Regards, Benjamin Block / Linux on IBM Z Kernel Development IBM Syste

Re: [dm-devel] bug: using smp_processor_id() in preemptible code in rr_select_path()

2016-08-08 Thread Benjamin Block
On 10:39 Mon 08 Aug , Jens Axboe wrote: > On 08/08/2016 10:32 AM, Benjamin Block wrote: > >On 12:06 Fri 05 Aug , Mike Snitzer wrote: > >>On Fri, Aug 05 2016 at 11:54am -0400, > >>Jens Axboe wrote: > >> > >>>On 08/05/2016 09:42 AM, Mike Sn

Re: [dm-devel] bug: using smp_processor_id() in preemptible code in rr_select_path()

2016-08-08 Thread Benjamin Block
/2016 09:27 AM, Mike Snitzer wrote: > > >>>On Wed, Aug 03 2016 at 11:35am -0400, > > >>>Benjamin Block wrote: > > >>> > > >>>>Hej Mike, > > >>>> > > >>>>when running a debug-kernel today with severa

Re: [dm-devel] bug: using smp_processor_id() in preemptible code in rr_select_path()

2016-08-07 Thread Benjamin Block
/2016 09:27 AM, Mike Snitzer wrote: > > >>>On Wed, Aug 03 2016 at 11:35am -0400, > > >>>Benjamin Block wrote: > > >>> > > >>>>Hej Mike, > > >>>> > > >>>>when running a debug-kernel today with severa

[dm-devel] bug: using smp_processor_id() in preemptible code in rr_select_path()

2016-08-03 Thread Benjamin Block
' and 'current_path'). The kernel is a stock v4.7 with some debug options enabled (prominently DEBUG_PREEMPT). Need any more info? Beste Grüße / Best regards, - Benjamin Block -- Lin