[dm-devel] [RFC PATCH 4/4] libmultipath: fix timeouts for path_latency prioritizer

2023-07-28 Thread Benjamin Marzinski
The path_latency prioritizer didn't call get_prio_timeout, so that the timeout could possibly be 0. Also, it was assuming that the timeout was in seconds, instead of milliseconds. Signed-off-by: Benjamin Marzinski --- libmultipath/prioritizers/path_latency.c | 5 +++-- 1 file changed, 3 insertio

[dm-devel] [RFC PATCH 0/4] Make prio timeouts work like checkers

2023-07-28 Thread Benjamin Marzinski
This patchset changes how prioritizers set their timeouts, to make them match how the checker functions work, and also cleans up some minor timeout issues. I did this to make out timeouts consistent, but if someone has a good reason to object to that, I don't feel strongly that it's necessary, and

[dm-devel] [RFC PATCH 3/4] libmultipath: fix timeouts for detect_alua()

2023-07-28 Thread Benjamin Marzinski
detect_alua calls prioritizer functions that expect the timeout to be in milliseconds instead of seconds. Fix this and also respect the checker_timeout setting. Signed-off-by: Benjamin Marzinski --- libmultipath/discovery.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --gi

[dm-devel] [RFC PATCH 2/4] libmultipath: make prioritizer timeouts work like checker timeouts

2023-07-28 Thread Benjamin Marzinski
Multipath's prioritizers previously didn't use the sysfs timeout for scsi devices, and used a prioritizer specific default timeout (although in practice, all the prioritizers except hds used 60 seconds). Now prioritizers deal with timeouts the same way as the checkers. They first use checker_time i

[dm-devel] [RFC PATCH 1/4] libmultipath: don't bother to reset default timeout value

2023-07-28 Thread Benjamin Marzinski
by the time get_state() is rechecking the sysfs timeout value, c->timeout has already been set. The only reason why this check exists is to deal with the possiblity that the sysfs value has changed. If the sysfs value doesn't exist (which likely means that the device is not a scsi device), then th

Re: [dm-devel] [git pull] device mapper fixes for 6.5-rc4

2023-07-28 Thread pr-tracker-bot
The pull request you sent on Thu, 27 Jul 2023 16:41:38 -0400: > git://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git > tags/for-6.5/dm-fixes has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/c75981a1be350f14dbfca56e62bea077dafdad96 Thank you! -- De

Re: [dm-devel] [PATCH v2 00/39] Add the dm-vdo deduplication and compression device mapper target.

2023-07-28 Thread Ken Raeburn
Mike Snitzer writes: > Thanks for the extra context, but a _big_ elephant in the room for > this line of discussion is that: the Linux workqueue code has > basically always been only available for use by GPL'd code. Given > VDO's historic non-GPL origins, it seems _to me_ that an alternative >