Re: [dm-devel] [PATCH V2] md: don't unregister sync_thread with reconfig_mutex held

2021-12-14 Thread Donald Buczek
On 14.12.21 11:03, Guoqing Jiang wrote: On 12/14/21 5:31 PM, Donald Buczek wrote:   -void md_reap_sync_thread(struct mddev *mddev) +void md_reap_sync_thread(struct mddev *mddev, bool reconfig_mutex_held)   {   struct md_rdev *rdev;   sector_t old_dev_sectors = mddev->dev_sectors;

Re: [dm-devel] [PATCH V2] md: don't unregister sync_thread with reconfig_mutex held

2021-12-14 Thread Donald Buczek
On 14.12.21 03:34, Guoqing Jiang wrote: On 12/10/21 10:16 PM, Donald Buczek wrote: Dear Guoqing, On 13.02.21 01:49, Guoqing Jiang wrote: Unregister sync_thread doesn't need to hold reconfig_mutex since it doesn't reconfigure array. And it could cause deadlock problem for raid5 as follows:

Re: [dm-devel] [PATCH] multipathd: avoid unnecessary path read-only reloads

2021-12-14 Thread Benjamin Marzinski
On Fri, Dec 03, 2021 at 08:25:00AM +, Martin Wilck wrote: > On Thu, 2021-11-18 at 16:47 -0600, Benjamin Marzinski wrote: > > +int > > +sysfs_get_ro (struct path *pp) > > +{ > > +   int ro; > > +   char buff[3]; /* Either "0\n\0" or "1\n\0" */ > > + > > +   if (!pp->udev) > > +  

Re: [dm-devel] [PATCH v2 03/48] libmultipath: add optional wakeup functionality to lock.c

2021-12-14 Thread Benjamin Marzinski
On Wed, Dec 01, 2021 at 01:06:45PM +0100, Martin Wilck wrote: > On Tue, 2021-11-30 at 21:28 +0100, Martin Wilck wrote: > > On Tue, 2021-11-30 at 10:52 -0600, Benjamin Marzinski wrote: > > > On Mon, Nov 29, 2021 at 09:52:49PM +0100, Martin Wilck wrote: > > > > I agree. Also, I realize that we've bum

Re: [PATCH 4/5] dax: remove the copy_from_iter and copy_to_iter methods

2021-12-14 Thread Dan Williams
On Tue, Dec 14, 2021 at 12:33 PM Vivek Goyal wrote: > > On Tue, Dec 14, 2021 at 08:41:30AM -0800, Dan Williams wrote: > > On Tue, Dec 14, 2021 at 6:23 AM Vivek Goyal wrote: > > > > > > On Mon, Dec 13, 2021 at 09:23:18AM +0100, Christoph Hellwig wrote: > > > > On Sun, Dec 12, 2021 at 06:44:26AM -0

Re: [PATCH 4/5] dax: remove the copy_from_iter and copy_to_iter methods

2021-12-14 Thread Vivek Goyal
On Tue, Dec 14, 2021 at 08:41:30AM -0800, Dan Williams wrote: > On Tue, Dec 14, 2021 at 6:23 AM Vivek Goyal wrote: > > > > On Mon, Dec 13, 2021 at 09:23:18AM +0100, Christoph Hellwig wrote: > > > On Sun, Dec 12, 2021 at 06:44:26AM -0800, Dan Williams wrote: > > > > On Fri, Dec 10, 2021 at 6:17 AM

Re: [PATCH 4/5] dax: remove the copy_from_iter and copy_to_iter methods

2021-12-14 Thread Dan Williams
On Tue, Dec 14, 2021 at 6:23 AM Vivek Goyal wrote: > > On Mon, Dec 13, 2021 at 09:23:18AM +0100, Christoph Hellwig wrote: > > On Sun, Dec 12, 2021 at 06:44:26AM -0800, Dan Williams wrote: > > > On Fri, Dec 10, 2021 at 6:17 AM Vivek Goyal wrote: > > > > Going forward, I am wondering should virtiof

Re: [PATCH 4/5] dax: remove the copy_from_iter and copy_to_iter methods

2021-12-14 Thread Vivek Goyal
On Mon, Dec 13, 2021 at 09:23:18AM +0100, Christoph Hellwig wrote: > On Sun, Dec 12, 2021 at 06:44:26AM -0800, Dan Williams wrote: > > On Fri, Dec 10, 2021 at 6:17 AM Vivek Goyal wrote: > > > Going forward, I am wondering should virtiofs use flushcache version as > > > well. What if host filesyste

Re: [PATCH 5/5] dax: always use _copy_mc_to_iter in dax_copy_to_iter

2021-12-14 Thread Vivek Goyal
On Sun, Dec 12, 2021 at 06:48:05AM -0800, Dan Williams wrote: > On Fri, Dec 10, 2021 at 6:05 AM Vivek Goyal wrote: > > > > On Thu, Dec 09, 2021 at 07:38:28AM +0100, Christoph Hellwig wrote: > > > While using the MC-safe copy routines is rather pointless on a virtual > > > device > > > like virtio

Re: [dm-devel] [PATCH V2] md: don't unregister sync_thread with reconfig_mutex held

2021-12-14 Thread Guoqing Jiang
On 12/14/21 5:31 PM, Donald Buczek wrote:   -void md_reap_sync_thread(struct mddev *mddev) +void md_reap_sync_thread(struct mddev *mddev, bool reconfig_mutex_held)   {   struct md_rdev *rdev;   sector_t old_dev_sectors = mddev->dev_sectors;   bool is_reshaped = false;     /*

Re: [dm-devel] [PATCH] dm integrity: Use struct_group() to zero struct journal_sector

2021-12-14 Thread Gustavo A. R. Silva
On Thu, Nov 18, 2021 at 12:36:40PM -0800, Kees Cook wrote: > In preparation for FORTIFY_SOURCE performing compile-time and run-time > field bounds checking for memset(), avoid intentionally writing across > neighboring fields. > > Add struct_group() to mark region of struct journal_sector that sho