Re: [dm-devel] [RFC PATCH 0/2] dm crypt: Allow unaligned buffer lengths for skcipher devices

2020-09-23 Thread Eric Biggers
On Wed, Sep 23, 2020 at 09:27:32PM -0400, Mike Snitzer wrote: > You've clearly done a nice job with these changes. Looks clean. > > BUT, I'm struggling to just accept that dm-crypt needs to go to these > extra lengths purely because of one bad apple usecase. > > These alignment constraints aren'

[dm-devel] [RFC PATCH v2 2/3] libmultipath: add uid failback for dasd devices

2020-09-23 Thread Benjamin Marzinski
Add failback code to get the uid for dasd devices from sysfs. Copied from dasdinfo Reviewed-by: Martin Wilck Signed-off-by: Benjamin Marzinski --- libmultipath/defaults.h | 1 + libmultipath/discovery.c | 37 - 2 files changed, 37 insertions(+), 1 deletion(

[dm-devel] [RFC PATCH v2 0/3] add library to check if device is a valid path

2020-09-23 Thread Benjamin Marzinski
The main part of the this patchset is the first patch, which adds a new library interface to check whether devices are valid paths. This was designed for use in the Storage Instantiation Daemon (SID). https://github.com/sid-project Hopefully, I've removed all the controvertial bits from the last

[dm-devel] [RFC PATCH v2 3/3] libmultipath: change log level for null uid_attribute

2020-09-23 Thread Benjamin Marzinski
If uid_attribute is explicitly set to an empty string, multipath should log the uid at the default log level, since using the fallback code is the expected behavior. Signed-off-by: Benjamin Marzinski --- libmultipath/discovery.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[dm-devel] [RFC PATCH v2 1/3] multipath: add libmpathvalid library

2020-09-23 Thread Benjamin Marzinski
This library allows other programs to check if a path should be claimed by multipath. It exports an init function, that needs to be called before and after all other library calls, an exit function, that needs to be called after all library calls, a function to reread the multipath configuration fi

Re: [dm-devel] [PATCH 6/6] mm: Add memalloc_nowait

2020-09-23 Thread Matthew Wilcox
files changed, 17 insertions(+), 26 deletions(-) > > > Hi, > > Curious on the state of this patchset? Not seeing it in next-20200923 > > The dm-bufio cleanup looks desirable. I've been busy with THPs and haven't pushed this patchset for this window. It'

Re: [dm-devel] [RFC PATCH 0/2] dm crypt: Allow unaligned buffer lengths for skcipher devices

2020-09-23 Thread Mike Snitzer
You've clearly done a nice job with these changes. Looks clean. BUT, I'm struggling to just accept that dm-crypt needs to go to these extra lengths purely because of one bad apple usecase. These alignment constraints aren't new. Are there other portions of Linux's crypto subsystem that needed c

Re: [dm-devel] [PATCH 2/3] dm: add support for passing through inline crypto support

2020-09-23 Thread Mike Snitzer
On Wed, Sep 09 2020 at 7:44pm -0400, Satya Tangirala wrote: > From: Eric Biggers > > Update the device-mapper core to support exposing the inline crypto > support of the underlying device(s) through the device-mapper device. > > This works by creating a "passthrough keyslot manager" for the d

Re: [dm-devel] [PATCH 2/3] dm: add support for passing through inline crypto support

2020-09-23 Thread Mike Snitzer
On Mon, Sep 21 2020 at 8:32pm -0400, Eric Biggers wrote: > On Wed, Sep 09, 2020 at 11:44:21PM +, Satya Tangirala wrote: > > From: Eric Biggers > > > > Update the device-mapper core to support exposing the inline crypto > > support of the underlying device(s) through the device-mapper devic

Re: [dm-devel] [PATCH v2 2/3] block: make blk_crypto_rq_bio_prep() able to fail

2020-09-23 Thread Mike Snitzer
On Tue, Sep 15 2020 at 11:53pm -0400, Eric Biggers wrote: > From: Eric Biggers > > blk_crypto_rq_bio_prep() assumes its gfp_mask argument always includes > __GFP_DIRECT_RECLAIM, so that the mempool_alloc() will always succeed. > > However, blk_crypto_rq_bio_prep() might be called with GFP_ATOM

Re: [dm-devel] [PATCH v2 1/3] block: make bio_crypt_clone() able to fail

2020-09-23 Thread Mike Snitzer
On Tue, Sep 15 2020 at 11:53pm -0400, Eric Biggers wrote: > From: Eric Biggers > > bio_crypt_clone() assumes its gfp_mask argument always includes > __GFP_DIRECT_RECLAIM, so that the mempool_alloc() will always succeed. > > However, bio_crypt_clone() might be called with GFP_ATOMIC via > setup

Re: [dm-devel] [PATCH 6/6] mm: Add memalloc_nowait

2020-09-23 Thread Mike Snitzer
e) > --- > drivers/md/dm-bufio.c| 30 -- > include/linux/sched.h| 1 + > include/linux/sched/mm.h | 12 > 3 files changed, 17 insertions(+), 26 deletions(-) Hi, Curious on the state of this patchset? Not seeing it in next-2

Re: [dm-devel] [git pull] device mapper fixes for 5.9 final

2020-09-23 Thread pr-tracker-bot
The pull request you sent on Wed, 23 Sep 2020 13:30:24 -0400: > git://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git > tags/for-5.9/dm-fixes-2 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/a969324fe7cc38e4af05eea44fde385a2853c91e Thank you! --

Re: [dm-devel] [RFC PATCH 0/2] dm crypt: Allow unaligned buffer lengths for skcipher devices

2020-09-23 Thread Sudhakar Panneerselvam
Could someone review this patch set, please? Thanks Sudhakar > -Original Message- > From: Sudhakar Panneerselvam > Sent: Wednesday, September 16, 2020 12:40 PM > To: a...@redhat.com; snit...@redhat.com; dm-devel@redhat.com > Cc: Shirley Ma ; ssudhak...@gmail.com; Martin > Petersen > Subj

[dm-devel] [PATCH 1/2] block: add QUEUE_FLAG_NOWAIT

2020-09-23 Thread Mike Snitzer
Add QUEUE_FLAG_NOWAIT to allow a block device to advertise support for REQ_NOWAIT. Bio-based devices may set QUEUE_FLAG_NOWAIT where applicable. Update QUEUE_FLAG_MQ_DEFAULT to include QUEUE_FLAG_NOWAIT. Also update submit_bio_checks() to verify it is set for REQ_NOWAIT bios. Reported-by: Konsta

[dm-devel] [PATCH 2/2] dm: add support for REQ_NOWAIT and enable it for linear target

2020-09-23 Thread Mike Snitzer
From: Konstantin Khlebnikov Add DM target feature flag DM_TARGET_NOWAIT which advertises that target works with REQ_NOWAIT bios. Add dm_table_supports_nowait() and update dm_table_set_restrictions() to set/clear QUEUE_FLAG_NOWAIT accordingly. Signed-off-by: Konstantin Khlebnikov Signed-off-by:

[dm-devel] [PATCH 0/2] block/dm: add REQ_NOWAIT support for bio-based

2020-09-23 Thread Mike Snitzer
Hi, I got guilted into this by this Twitter exchange: https://twitter.com/axboe/status/1308778488011337728 Started with this patchset from June and revised it: https://patchwork.kernel.org/project/dm-devel/list/?series=297693 (dropped MD patch while doing so_. Tested these changes with this test

[dm-devel] [git pull] device mapper fixes for 5.9 final

2020-09-23 Thread Mike Snitzer
Hi Linus, The following changes since commit beaeb4f39bc31d5a5eb6d05465a86af4fe147732: Merge tag 'for-linus' of git://git.kernel.org/pub/scm/virt/kvm/kvm (2020-09-21 08:53:48 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm

Re: [dm-devel] [PATCH v3 0/6] dm: fix then improve bio splitting

2020-09-23 Thread Jens Axboe
On 9/21/20 8:32 PM, Mike Snitzer wrote: > Hi, > > Patches 1 and 2 are queued for me to send to Linus later this week. > > Patches 3 and 4 are block core and should get picked up for 5.10. > Jens, please pick them up. I revised the header for patch 4 to give > better context for use-case where non

Re: [dm-devel] [PATCH 17/19] libmultipath: add udev and logsink symbols

2020-09-23 Thread Benjamin Marzinski
On Wed, Sep 23, 2020 at 10:16:48AM +0200, Martin Wilck wrote: > On Mon, 2020-09-21 at 15:10 -0500, Benjamin Marzinski wrote: > > > > After calling libmultipath_exit(), you can never reinitialized the > > udev > > device. That seems fine, but it should probably set udev to null, so > > that future

Re: [dm-devel] [PATCH 05/13] bdi: initialize ->ra_pages and ->io_pages in bdi_init

2020-09-23 Thread Christoph Hellwig
On Tue, Sep 22, 2020 at 10:49:54AM +0200, Jan Kara wrote: > On Mon 21-09-20 10:07:26, Christoph Hellwig wrote: > > Set up a readahead size by default, as very few users have a good > > reason to change it. > > > > Signed-off-by: Christoph Hellwig > > Acked-by: David Sterba [btrfs] > > Acked-by:

[dm-devel] [PATCH] libmultipath: Allow discovery of USB devices

2020-09-23 Thread Frank Meinl
This change adds a new configuration option allow_usb_devices. It is disabled by default, so that the behavior of existing setups is not changed. If enabled (via multipath.conf), USB devices will be found during device discovery and can be used for multipath setups. Without this option, multipath

Re: [dm-devel] [PATCH 17/19] libmultipath: add udev and logsink symbols

2020-09-23 Thread Martin Wilck
On Mon, 2020-09-21 at 15:10 -0500, Benjamin Marzinski wrote: > > After calling libmultipath_exit(), you can never reinitialized the > udev > device. That seems fine, but it should probably set udev to null, so > that future calls to libmultipath_init() don't return success. Either > that or multi