In cli_getprkey func, we use MALLOC instead of malloc, and check
the return value of MALLOC.
V1->V2: turn back MALLOC to malloc and reomve error message
Signed-off-by: Zhiqiang Liu
Signed-off-by: Lixiaokeng
Signed-off-by: Linfeilong
---
multipathd/cli_handlers.c | 2 ++
1 file changed, 2 inse
In mpath_pr_event_handler_fn, we use MALLOC instead of malloc, and check
the return value of MALLOC.
V1->V2: delete seting ret when jump to out
Signed-off-by: Lixiaokeng
Signed-off-by: Zhiqiang Liu
Signed-off-by: Linfeilong
---
multipathd/main.c | 8
1 file changed, 4 insertions(+),
We check the return value of malloc in print_foreign_topology.
V1->V2: chanege malloc to calloc
Signed-off-by: Lixiaokeng
Signed-off-by: Zhiqiang Liu
Signed-off-by: Linfeilong
---
libmultipath/foreign.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libmultipath/forei
If dm_get_major_minor failed, log with major and minor should not
be printed to avoid major and minor used before initialization.
V1->V2: set major and minor to -1 at begining
Signed-off-by: Lixiaokeng
Signed-off-by: Zhiqiang Liu
Signed-off-by: Linfeilong
---
multipathd/cli_handlers.c | 2 +-
Patches 01, 02, 04, 05, 06, 09, 11, 12, 14 have some changes.
Changes in V2:
- patch 01: set major and minor to -1 at begining, as suggested
by Martin Wilck
- patch 02: chanege malloc to calloc to calloc, as suggested by
Martin Wilck
- patch 04: delete seting ret when jump to out, as suggested
Hi, Jens Axboe, Alasdair Kergon, Mike Snitzer:
What's your opinion?
On 2020/8/21 15:05, Coly Li wrote:
> On 2020/8/21 14:48, Leizhen (ThunderTown) wrote:
>>
>>
>> On 8/21/2020 12:11 PM, Coly Li wrote:
>>> On 2020/8/21 10:03, Zhen Lei wrote:
There are too many PAGE_SECTORS definitions, and
Hello all,
>From my earlier post:
https://www.redhat.com/archives/dm-devel/2020-September/msg00083.html
Would it be better to move the unsetting the address of sdev to NULL lower?
This would protect
against the crash we see when the alua_rtpg function tries to access the sdev
address
that has b
On Fri, 2020-09-04 at 19:05 -0500, Benjamin Marzinski wrote:
> On Wed, Sep 02, 2020 at 03:24:33PM +0800, lixiaokeng wrote:
> > The return values of dm_get_map, disassemble_map in get_mpvec
> > were not checked. Use update_multipath_table/status to instead
> > of them.
> >
>
> Looks mostly good. I
> Looks mostly good. I agree that we should be checking the results of
> getting the raw data before we try to disassemble it. But, there's not
> really any point to calling continue as the last operation of a loop.
> Perhaps
>
> if (update_multipath_table(mpp, pathvec, DI_CHECKER) == DMP_OK)
>
>>
>> -paramp= malloc(sizeof(struct prout_param_descriptor) +
>> (sizeof(struct transportid *)*(MPATH_MX_TIDS )));
>> -
>> -memset(paramp, 0, sizeof(struct prout_param_descriptor) +
>> (sizeof(struct transportid *)*(MPATH_MX_TIDS)));
>
> When looking at your patch, I no
>> @@ -86,9 +86,12 @@ assemble_map (struct multipath * mp, char * params, int
>> len)
>> get_linux_version_code() < KERNEL_VERSION(4, 3, 0))
>> add_feature(&mp->features, retain_hwhandler);
>>
>> -f = STRDUP(mp->features);
>
> clearly strdup()ing without checking if mp
Hi Ben:
I think you are right. We should not keep them with partial information.
Thanks for your review.
-Lixiaokeng
On 2020/9/5 5:11, Benjamin Marzinski wrote:
> On Wed, Sep 02, 2020 at 03:20:29PM +0800, lixiaokeng wrote:
>> In merge_words func, if REALLOC() fails, the input *dst will
>> be fr
12 matches
Mail list logo
