Re: [dm-devel] [git pull] device mapper fixes for 5.6-rc5

2020-03-04 Thread Theodore Y. Ts'o
On Wed, Mar 04, 2020 at 02:23:35PM -0500, Mike Snitzer wrote: > > These versions are for userspace's benefit (be it lvm2, cryptsetup, > multipath-tools, etc). But yes, these versions are bogus even for > that -- primarily because it requires userspace to know when a > particular feature/fix it ca

Re: [dm-devel] [git pull] device mapper fixes for 5.6-rc5

2020-03-04 Thread Linus Torvalds
On Wed, Mar 4, 2020, 13:23 Mike Snitzer wrote: > > These versions are for userspace's benefit (be it lvm2, cryptsetup, > multipath-tools, etc). But yes, these versions are bogus even for > that -- primarily because it requires userspace to know when a > particular feature/fix it cares about was

Re: [dm-devel] [git pull] device mapper fixes for 5.6-rc5

2020-03-04 Thread Mike Snitzer
On Wed, Mar 04 2020 at 2:06pm -0500, Linus Torvalds wrote: > On Wed, Mar 4, 2020 at 9:03 AM Mike Snitzer wrote: > > > > - Bump the minor version for DM core and all target versions that have > > seen interface changes or important fixes during the 5.6 cycle. > > Can we please remove these po

Re: [dm-devel] [git pull] device mapper fixes for 5.6-rc5

2020-03-04 Thread pr-tracker-bot
The pull request you sent on Wed, 4 Mar 2020 10:02:57 -0500: > git://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git > tags/for-5.6/dm-fixes has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/776e49e8ddb5169e6477fd33a396e9c7b2eb7400 Thank you! -- Dee

Re: [dm-devel] [git pull] device mapper fixes for 5.6-rc5

2020-03-04 Thread Linus Torvalds
On Wed, Mar 4, 2020 at 9:03 AM Mike Snitzer wrote: > > - Bump the minor version for DM core and all target versions that have > seen interface changes or important fixes during the 5.6 cycle. Can we please remove these pointless version markers entirely? They make no sense. The kernel doesn't

Re: [dm-devel] [PATCH v6 1/6] pmem: Add functions for reading/writing page to/from pmem

2020-03-04 Thread Vivek Goyal
On Sat, Feb 29, 2020 at 09:04:00AM +0100, Pankaj Gupta wrote: > On Fri, 28 Feb 2020 at 17:35, Vivek Goyal wrote: > > > > This splits pmem_do_bvec() into pmem_do_read() and pmem_do_write(). > > pmem_do_write() will be used by pmem zero_page_range() as well. Hence > > sharing the same code. > > > >

Re: [dm-devel] [PATCH v6 1/6] pmem: Add functions for reading/writing page to/from pmem

2020-03-04 Thread Christoph Hellwig
On Sat, Feb 29, 2020 at 09:04:00AM +0100, Pankaj Gupta wrote: > > + phys_addr_t pmem_off = sector * 512 + pmem->data_offset; > > minor nit, maybe 512 is replaced by macro? Looks like its used at multiple > places, maybe can keep at is for now. That would be the existing SECTOR_SIZE macro.

[dm-devel] [git pull] device mapper fixes for 5.6-rc5

2020-03-04 Thread Mike Snitzer
Hi Linus, The following changes since commit 47ace7e012b9f7ad71d43ac9063d335ea3d6820b: dm: fix potential for q->make_request_fn NULL pointer (2020-01-27 14:52:36 -0500) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git tags/fo