Re: [dm-devel] [PATCH v5 2/8] drivers/pmem: Allow pmem_clear_poison() to accept arbitrary offset and len

2020-02-24 Thread Dan Williams
On Mon, Feb 24, 2020 at 1:53 PM Jeff Moyer wrote: > > Dan Williams writes: > > >> Let's just focus on reporting errors when we know we have them. > > > > That's the problem in my eyes. If software needs to contend with > > latent error reporting then it should always contend otherwise > > softwar

Re: [dm-devel] [PATCH v5 2/8] drivers/pmem: Allow pmem_clear_poison() to accept arbitrary offset and len

2020-02-24 Thread Jeff Moyer
Dan Williams writes: >> Let's just focus on reporting errors when we know we have them. > > That's the problem in my eyes. If software needs to contend with > latent error reporting then it should always contend otherwise > software has multiple error models to wrangle. The only way for an appli

Re: [dm-devel] [PATCH v5 2/8] drivers/pmem: Allow pmem_clear_poison() to accept arbitrary offset and len

2020-02-24 Thread Dan Williams
On Mon, Feb 24, 2020 at 1:17 PM Vivek Goyal wrote: > > On Mon, Feb 24, 2020 at 12:52:13PM -0800, Dan Williams wrote: > > On Mon, Feb 24, 2020 at 12:13 PM Vivek Goyal wrote: > > > > > > On Mon, Feb 24, 2020 at 10:03:30AM +1100, Dave Chinner wrote: > > > > On Fri, Feb 21, 2020 at 03:17:59PM -0500,

Re: [dm-devel] [PATCH v5 2/8] drivers/pmem: Allow pmem_clear_poison() to accept arbitrary offset and len

2020-02-24 Thread Vivek Goyal
On Mon, Feb 24, 2020 at 12:52:13PM -0800, Dan Williams wrote: > On Mon, Feb 24, 2020 at 12:13 PM Vivek Goyal wrote: > > > > On Mon, Feb 24, 2020 at 10:03:30AM +1100, Dave Chinner wrote: > > > On Fri, Feb 21, 2020 at 03:17:59PM -0500, Vivek Goyal wrote: > > > > On Fri, Feb 21, 2020 at 01:32:48PM -0

Re: [dm-devel] [PATCH v5 2/8] drivers/pmem: Allow pmem_clear_poison() to accept arbitrary offset and len

2020-02-24 Thread Dan Williams
On Mon, Feb 24, 2020 at 12:13 PM Vivek Goyal wrote: > > On Mon, Feb 24, 2020 at 10:03:30AM +1100, Dave Chinner wrote: > > On Fri, Feb 21, 2020 at 03:17:59PM -0500, Vivek Goyal wrote: > > > On Fri, Feb 21, 2020 at 01:32:48PM -0500, Jeff Moyer wrote: > > > > Vivek Goyal writes: > > > > > > > > > On

Re: [dm-devel] [PATCH v5 2/8] drivers/pmem: Allow pmem_clear_poison() to accept arbitrary offset and len

2020-02-24 Thread Dan Williams
On Mon, Feb 24, 2020 at 5:50 AM Jeff Moyer wrote: > > Dan Williams writes: > > > On Sun, Feb 23, 2020 at 3:03 PM Dave Chinner wrote: > >> > >> On Fri, Feb 21, 2020 at 03:17:59PM -0500, Vivek Goyal wrote: > >> > On Fri, Feb 21, 2020 at 01:32:48PM -0500, Jeff Moyer wrote: > >> > > Vivek Goyal wri

Re: [dm-devel] [PATCH v5 2/8] drivers/pmem: Allow pmem_clear_poison() to accept arbitrary offset and len

2020-02-24 Thread Vivek Goyal
On Mon, Feb 24, 2020 at 10:03:30AM +1100, Dave Chinner wrote: > On Fri, Feb 21, 2020 at 03:17:59PM -0500, Vivek Goyal wrote: > > On Fri, Feb 21, 2020 at 01:32:48PM -0500, Jeff Moyer wrote: > > > Vivek Goyal writes: > > > > > > > On Thu, Feb 20, 2020 at 04:35:17PM -0500, Jeff Moyer wrote: > > > >>

Re: [dm-devel] [PATCH v5 2/8] drivers/pmem: Allow pmem_clear_poison() to accept arbitrary offset and len

2020-02-24 Thread Vivek Goyal
On Mon, Feb 24, 2020 at 10:03:30AM +1100, Dave Chinner wrote: [..] > > > > Hi Jeff, > > > > > > > > New dax zeroing interface (dax_zero_page_range()) can technically pass > > > > a range which is less than a sector. Or which is bigger than a sector > > > > but start and end are not aligned on sect

[dm-devel] [Job Posting] There is a position open in Red Hat for working on device-mapper

2020-02-24 Thread Brassow Jonathan
Hi, Apologies for hijacking the mailing list to solicit job postings, but this one seems especially on-point. We have a job opening in Red Hat for device-mapper and related products development. The position and salary are based in Brno, Czech Republic; but working remotely from just about an

Re: [dm-devel] [PATCH v5 2/8] drivers/pmem: Allow pmem_clear_poison() to accept arbitrary offset and len

2020-02-24 Thread Jeff Moyer
Dan Williams writes: > On Sun, Feb 23, 2020 at 3:03 PM Dave Chinner wrote: >> >> On Fri, Feb 21, 2020 at 03:17:59PM -0500, Vivek Goyal wrote: >> > On Fri, Feb 21, 2020 at 01:32:48PM -0500, Jeff Moyer wrote: >> > > Vivek Goyal writes: >> > > >> > > > On Thu, Feb 20, 2020 at 04:35:17PM -0500, Jef

Re: [dm-devel] [PATCH v3] dm ebs: new block size emulating target

2020-02-24 Thread Damien Le Moal
Heinz, On 2020/02/21 23:25, Heinz Mauelshagen wrote: > Hi Damien, > > thanks for your review, much appreciated. > > Please find my statements inline with yours below, working in > uncontroversial ones now... > > Heinz > > > On 2/21/20 10:44 AM, Damien Le Moal wrote: >> On 2020/02/20 7:12, he

Re: [dm-devel] [PATCH v3] dm ebs: new block size emulating target

2020-02-24 Thread Damien Le Moal
On 2020/02/22 0:20, Heinz Mauelshagen wrote: > Bryan, > > thanks for the review and testing. > > See remarks below. > > Heinz > > > On 2/21/20 4:08 PM, Bryan Gurney wrote: >> On Fri, Feb 21, 2020 at 9:26 AM Heinz Mauelshagen wrote: >>> Hi Damien, >>> >>> thanks for your review, much appreciat

[dm-devel] [PATCH 1/7] dm: report suspended device during destroy

2020-02-24 Thread Mikulas Patocka
The function dm_suspended returns true if the target is suspended. However, when the target is being suspended during unload, it returns false. This patch makes dm_suspended return true after the presuspend hook before the presuspend hook - just like during a normal suspend. It allows simplifying

[dm-devel] [PATCH 5/7] dm writecache: implement the "cleaner" policy

2020-02-24 Thread Mikulas Patocka
The messages flush or flush_on_suspend flush the whole cache. However, flushing can take some time and the process would be in an interruptible state during the flush. This patch implements an alternate flusing method - the "cleaner" option. When this option is activated (either by a message or in

[dm-devel] [PATCH 2/7] dm-writecache: fix a crash when unloading

2020-02-24 Thread Mikulas Patocka
This patch fixes a crash in writecache_writeback when replacing the dm-writecache target: general protection fault: [#1] SMP PTI CPU: 28 PID: 6388 Comm: kworker/28:2 Kdump: loaded Tainted: GW - -t - 4.18.0-173.el8.x86_64 #1 Hardware name: Dell Inc. PowerEdge R830/0V

[dm-devel] [PATCH 0/7] dm-writecache patches

2020-02-24 Thread Mikulas Patocka
Hi Here I'm sending my dm-writecache patches. The first three patches should be backported to the stable kernels because they fix bugs. The next four patches are enhancements that should be queued for the next merge window. Mikulas -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.

[dm-devel] [PATCH 3/7] dm writecache: verify watermark on resume

2020-02-24 Thread Mikulas Patocka
Verify the watermark after resume - so that if the target is reloaded with lower watermark, it will start the cleanup process immediatelly. Signed-off-by: Mikulas Patocka Cc: sta...@vger.kernel.org #av4.18+ Fixes: 48debafe4f2f ("dm: add writecache target") --- drivers/md/dm-writecache.c |

[dm-devel] [PATCH 6/7] dm-writecache: implement gradual cleanup

2020-02-24 Thread Mikulas Patocka
This patch implements gradual cleanup for dm-writecache - if the block is stored in the cache for too long, it will be written to the underlying device and cleaned up. The patch adds a new option "max_age" that specified the maximum age of a block in milliseconds. Signed-off-by: Mikulas Patocka

[dm-devel] [PATCH 4/7] dm writecache: do direct write if the cache is full

2020-02-24 Thread Mikulas Patocka
If the cache device is full, we do a direct write to the origin device. Note that we must not do it if the written block is already in the cache. Signed-off-by: Mikulas Patocka --- drivers/md/dm-writecache.c | 13 + 1 file changed, 13 insertions(+) Index: linux-2.6/drivers/md/dm-

[dm-devel] [PATCH 7/7] dm writecache: optimize superblock write

2020-02-24 Thread Mikulas Patocka
If we write a superblock in writecache_flush, we don't need to set bit and scan the bitmap for it - we can just write the superblock directly. Also, we can set the flag REQ_FUA on the write bio, so that we don't need to submit a flush bio afterwards. Signed-off-by: Mikulas Patocka --- drivers/m