On Mon, Feb 10, 2020 at 06:08:14PM +0100, Martin Wilck wrote:
> On Wed, 2020-02-05 at 12:58 -0600, Benjamin Marzinski wrote:
> > On systems with a large number of cores (>500), io_destroy() can take
> > tens to hundreds of milliseconds to complete, due to RCU
> > synchronization. If there are a lar
On Mon, Feb 10, 2020 at 02:49:38PM +, Martin Wilck wrote:
> On Wed, 2020-02-05 at 12:58 -0600, Benjamin Marzinski wrote:
> > This adds the wildcard 'g' for multipath and path formatted printing,
> > which returns extra data from a device's vendor specific vpd
> > page. The
> > specific vendor
Yeah, that's a great point. Now that I've reviewed the code a little
more, I understand how it's not safe to do the thing I described in
the first place, and how this change is safe and correct.
Please feel free to add my
Reviewed-by: John Dorminy
Thanks!
On Fri, Feb 7, 2020 at 3:07 PM Mikula
On Wed, 2020-02-05 at 12:58 -0600, Benjamin Marzinski wrote:
> There is now a file in tests called directio_test_dev. If the
> commented
> out test device line is uncommented and set to a device, it can be
> used
> to test the directio checker on that device, instead of faking the
> device.
>
> Si
On Wed, 2020-02-05 at 12:58 -0600, Benjamin Marzinski wrote:
> Signed-off-by: Benjamin Marzinski
> ---
> tests/Makefile | 3 +-
> tests/directio.c | 704
> +++
> 2 files changed, 706 insertions(+), 1 deletion(-)
> create mode 100644 tests/directio.
On Wed, 2020-02-05 at 12:58 -0600, Benjamin Marzinski wrote:
> On systems with a large number of cores (>500), io_destroy() can take
> tens to hundreds of milliseconds to complete, due to RCU
> synchronization. If there are a large number of paths using the directio
> checker on such a system, this
On Wed, 2020-02-05 at 12:58 -0600, Benjamin Marzinski wrote:
> This adds the wildcard 'g' for multipath and path formatted printing,
> which returns extra data from a device's vendor specific vpd
> page. The
> specific vendor vpd page to use, and the vendor/product id to decode
> it
> can be set i
On Wed, 2020-02-05 at 12:58 -0600, Benjamin Marzinski wrote:
> multipath will try to get the priority from a PATH_DOWN path, if the
> path doesn't currently have a valid priority. However, if the
> priority
> code needs to contact the device to get the priority, this is likely
> to
> fail for PATH_
This new target is similar to the linear target except that it emulates
a smaller logical block size on devices with larger ones. It's main
purpose is to emulate 512 byte sectors on 4K native disks (i.e. 512e).
See Documentaiton/admn-guide/device-mapper/dm-ebs.rst for details.
Signed-off-by: Hei
On Wed, 2020-02-05 at 12:58 -0600, Benjamin Marzinski wrote:
> If do_inq returns a page with a length that is less than maxlen, but
> larger than DEFAULT_SGIO_LEN, this function will loop forever. Also
> if do_inq returns with a length equal to or greater than maxlen,
> sgio_get_vpd will exit immed
On Wed, 2020-02-05 at 12:58 -0600, Benjamin Marzinski wrote:
> Signed-off-by: Benjamin Marzinski
> ---
> multipathd/uxlsnr.c | 12 ++--
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
Reviewed-by: Martin Wilck
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/m
On Wed, 2020-02-05 at 12:58 -0600, Benjamin Marzinski wrote:
> It would be helpful if multipathd could log a message when
> multipath.conf or files in the config_dir have been written to, both
> so
> that it can be used to send a notification to users, and to help with
> determining after the fact
This adds support for REQ_ALLOCATE extension of REQ_OP_WRITE_ZEROES
operation, which encourages a block device driver to just allocate
blocks (or mark them allocated) instead of actual blocks zeroing.
REQ_ALLOCATE is aimed to be used for network filesystems providing
a block device interface. Also,
This is a preparation for next patch, which introduces
a new flag BLKDEV_ZERO_ALLOCATE for calls, which need
only allocation of blocks and don't need actual blocks
zeroing.
Signed-off-by: Kirill Tkhai
Reviewed-by: Bob Liu
Reviewed-by: Martin K. Petersen
---
block/blk-lib.c
If config_dir contains a file named, for example, "some.conf.backup", this file
will still be loaded by multipath because process_config_dir()
(libmultipath/config.c) uses strstr() to check for the ".conf" extension, but
that doesn't guarantee that ".conf" is at the end of the filename.
This patch
(was "[PATCH block v2 0/3] block: Introduce REQ_NOZERO flag
for REQ_OP_WRITE_ZEROES operation";
was "[PATCH RFC 0/3] block,ext4: Introduce REQ_OP_ASSIGN_RANGE
to reflect extents allocation in block device internals")
v6: req_op() cosmetic change.
v5: Kill dm|md patch, which disables
This introduces a new primitive, which returns max sectors
for REQ_OP_WRITE_ZEROES operation.
@op_flags is unused now, and it will be enabled in next patch.
Signed-off-by: Kirill Tkhai
Reviewed-by: Bob Liu
---
block/blk-core.c |2 +-
block/blk-merge.c |9 ++---
include/li
Support for new modifier of REQ_OP_WRITE_ZEROES command.
This results in allocation extents in backing file instead
of actual blocks zeroing.
Signed-off-by: Kirill Tkhai
Reviewed-by: Bob Liu
---
drivers/block/loop.c | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff
This preparation patch changes argument type, and now
the function takes full op_flags instead of just op code.
Signed-off-by: Kirill Tkhai
Reviewed-by: Bob Liu
---
block/blk-core.c |4 ++--
include/linux/blkdev.h |8 +---
2 files changed, 7 insertions(+), 5 deletions(-)
diff
This is a new helper to assign max_allocate_sectors
limit of block device queue.
Signed-off-by: Kirill Tkhai
Reviewed-by: Bob Liu
---
block/blk-settings.c | 13 +
include/linux/blkdev.h |2 ++
2 files changed, 15 insertions(+)
diff --git a/block/blk-settings.c b/block/blk-s
20 matches
Mail list logo
