Re: [dm-devel] xts fuzz testing and lack of ciphertext stealing support

2019-07-26 Thread Ard Biesheuvel
On Sat, 27 Jul 2019 at 00:43, Pascal Van Leeuwen wrote: > > > -Original Message- > > From: Horia Geanta > > Sent: Friday, July 26, 2019 9:59 PM > > To: Pascal Van Leeuwen ; Ard Biesheuvel > > > > Cc: Milan Broz ; Herbert Xu > > ; dm-devel@redhat.com; linux- > > cry...@vger.kernel.org >

Re: [dm-devel] [scsi] ae86a1c553: BUG:kernel_NULL_pointer_dereference, address

2019-07-26 Thread Ming Lei
Hi, Thanks for your report! On Thu, Jul 25, 2019 at 06:46:29PM +0800, kernel test robot wrote: > FYI, we noticed the following commit (built with gcc-7): > > commit: ae86a1c5530b52dc44a280e78feb0c4eb2dd8595 ("[PATCH V2 2/2] scsi: > implement .cleanup_rq callback") > url: > https://github.com/0

RE: [dm-devel] xts fuzz testing and lack of ciphertext stealing support

2019-07-26 Thread Pascal Van Leeuwen
> -Original Message- > From: Horia Geanta > Sent: Friday, July 26, 2019 9:59 PM > To: Pascal Van Leeuwen ; Ard Biesheuvel > > Cc: Milan Broz ; Herbert Xu > ; dm-devel@redhat.com; linux- > cry...@vger.kernel.org > Subject: Re: [dm-devel] xts fuzz testing and lack of ciphertext stealing

Re: [dm-devel] xts fuzz testing and lack of ciphertext stealing support

2019-07-26 Thread Horia Geanta
On 7/26/2019 1:31 PM, Pascal Van Leeuwen wrote: > Ok, find below a patch file that adds your vectors from the specification > plus my set of additional vectors covering all CTS alignments combined > with the block sizes you desired. Please note though that these vectors > are from our in-house home

[dm-devel] [PATCH] multipath-tools: delete examples from mpathpersist output

2019-07-26 Thread Xose Vazquez Perez
The manual page is more complete and detailed. Cc: Christophe Varoqui Cc: DM-DEVEL ML Signed-off-by: Xose Vazquez Perez --- mpathpersist/main.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/mpathpersist/main.c b/mpathpersist/main.c index 5ad06a9..c451855 100644 ---

[dm-devel] [PATCH] multipath-tools: delete outdated comment at multipath/multipath.conf.5

2019-07-26 Thread Xose Vazquez Perez
Cc: Christophe Varoqui Cc: DM-DEVEL ML Signed-off-by: Xose Vazquez Perez --- multipath/multipath.conf.5 | 2 -- 1 file changed, 2 deletions(-) diff --git a/multipath/multipath.conf.5 b/multipath/multipath.conf.5 index f7d21b4..880947f 100644 --- a/multipath/multipath.conf.5 +++ b/multipath/mul

[dm-devel] [PATCH] multipath-tools: reorder vendor in hwtable

2019-07-26 Thread Xose Vazquez Perez
Nexenta was acquired by DDN. Cc: Yacine Kheddache Cc: Christophe Varoqui Cc: DM-DEVEL ML Signed-off-by: Xose Vazquez Perez --- libmultipath/hwtable.c | 23 +++ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c i

RE: [dm-devel] xts fuzz testing and lack of ciphertext stealing support

2019-07-26 Thread Pascal Van Leeuwen
Ard, > -Original Message- > From: Ard Biesheuvel > Sent: Thursday, July 25, 2019 10:02 AM > To: Pascal Van Leeuwen > Cc: Milan Broz ; Herbert Xu > ; dm-devel@redhat.com; linux- > cry...@vger.kernel.org; Horia Geanta > Subject: Re: [dm-devel] xts fuzz testing and lack of ciphertext stea

Re: [PATCH v8 1/7] crypto: essiv - create wrapper template for ESSIV generation

2019-07-26 Thread Ard Biesheuvel
On Fri, 26 Jul 2019 at 07:31, Herbert Xu wrote: > > Ard Biesheuvel wrote: > > > > + * The typical use of this template is to instantiate the skcipher > > + * 'essiv(cbc(aes),aes,sha256)', which is the only instantiation used by > > + * fscrypt, and the most relevant one for dm-crypt. However, dm-

Re: [dm-devel] [PATCH V3 1/2] blk-mq: add callback of .cleanup_rq

2019-07-26 Thread Sasha Levin
Hi, [This is an automated email] This commit has been processed because it contains a "Fixes:" tag, fixing commit: 396eaf21ee17 blk-mq: improve DM's blk-mq IO merging via blk_insert_cloned_request feedback. The bot has tested the following trees: v5.2.2, v5.1.19, v4.19.60. v5.2.2: Build OK! v5

[dm-devel] [PATCH V3 0/2] block/scsi/dm-rq: fix leak of request private data in dm-mpath

2019-07-26 Thread Ming Lei
Hi, When one request is dispatched to LLD via dm-rq, if the result is BLK_STS_*RESOURCE, dm-rq will free the request. However, LLD may allocate private data for this request, so this way will cause memory leak. Add .cleanup_rq() callback and implement it in SCSI for fixing the issue, since SCSI i

[dm-devel] [PATCH V4 0/2] block/scsi/dm-rq: fix leak of request private data in dm-mpath

2019-07-26 Thread Ming Lei
Hi, When one request is dispatched to LLD via dm-rq, if the result is BLK_STS_*RESOURCE, dm-rq will free the request. However, LLD may allocate private data for this request, so this way will cause memory leak. Add .cleanup_rq() callback and implement it in SCSI for fixing the issue, since SCSI i