Re: [dm-devel] [git pull] device mapper fixes for 5.0-rc6

2019-02-07 Thread pr-tracker-bot
The pull request you sent on Thu, 7 Feb 2019 11:58:40 -0500: > git://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git > tags/for-5.0/dm-fixes-2 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/8b5cdbe595a05b8c767d9fe779bd47e997f934c9 Thank you! -- D

[dm-devel] [PATCH 0/4] multipath: fixes for invalid path device handling

2019-02-07 Thread Benjamin Marzinski
I recently got a bug from a user with a bad property blacklist_exceptions line, where multipath tried to use a zram device, which caused multipathd to crash. This patch set fixes that crash, and then adds some additional safeguards to prevent things like this happening in the future. The first pat

[dm-devel] [PATCH 1/4] multipathd: avoid null pointer dereference in LOG_MSG

2019-02-07 Thread Benjamin Marzinski
LOG_MSG() will dereference pp->mpp. Commit cb5ec664 added a call to LOG_MSG() before the check for (!pp->mpp) in check_path. This can cause multipathd to crash. LOG_MSG() should only be called if pp->mpp is set and a checker is selected. Also, checker_message() should fail to a generic message i

[dm-devel] [PATCH 3/4] multipathd: fix pp->initialized state ping-ponging

2019-02-07 Thread Benjamin Marzinski
When a multipath device fails to get a wwid in pathinfo, it moves to the INIT_MISSING_UDEV state. After a device in this state sends retrigger_tries change uevents in check_path(), it moves to the INIT_FAILED state. However, when check_path() is run on a device in INIT_FAILED, it can call pathinfo

[dm-devel] [PATCH 4/4] multipathd: don't resend change events for unknown devices

2019-02-07 Thread Benjamin Marzinski
If multipath fails to get the wwid for a device, and the device is of an unknown type (pp->bus == SYSFS_BUS_UNDEF), don't send change events. Instead, assume that the device was not meant to be used and skip it. Signed-off-by: Benjamin Marzinski --- libmultipath/discovery.c | 2 ++ 1 file change

[dm-devel] [PATCH 2/4] multipath: blacklist zram devices

2019-02-07 Thread Benjamin Marzinski
Signed-off-by: Benjamin Marzinski --- libmultipath/blacklist.c | 2 +- multipath/multipath.conf.5 | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libmultipath/blacklist.c b/libmultipath/blacklist.c index 709895e..e0d0279 100644 --- a/libmultipath/blacklist.c +++ b/libmult

[dm-devel] [git pull] device mapper fixes for 5.0-rc6

2019-02-07 Thread Mike Snitzer
Hi Linus, Both of these fixes address issues in changes merged for 5.0-rc4. The following changes since commit 8834f5600cf3c8db365e18a3d5cac2c2780c81e5: Linux 5.0-rc5 (2019-02-03 13:48:04 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/device-ma