Re: [dm-devel] [git pull] device mapper changes for 4.21

2019-01-02 Thread Milan Broz
On 03/01/2019 08:27, Christoph Hellwig wrote: > On Sun, Dec 30, 2018 at 04:25:46PM -0800, Linus Torvalds wrote: >> On Sun, Dec 30, 2018 at 11:15 AM Mikulas Patocka wrote: >>> >>> But you're right that 2TiB devices are common and that perhaps this option >>> should go away. >> >> 2TiB devices are d

Re: [dm-devel] [git pull] device mapper changes for 4.21

2019-01-02 Thread Christoph Hellwig
On Sun, Dec 30, 2018 at 04:25:46PM -0800, Linus Torvalds wrote: > On Sun, Dec 30, 2018 at 11:15 AM Mikulas Patocka wrote: > > > > But you're right that 2TiB devices are common and that perhaps this option > > should go away. > > 2TiB devices are definitely not common in the one situation where th

[dm-devel] [PATCH] dm: give req_size precisely given by user

2019-01-02 Thread Jaegeuk Kim
This patch makes dm be aware of io_pages to assign sane req_size for reads. Cc: sta...@vger.kernel.org Cc: Jens Axboe Cc: Alasdair Kergon Cc: Mike Snitzer Cc: dm-devel@redhat.com Fixes: 9491ae4a ("mm: don't cap request size based on read-ahead setting") Signed-off-by: Jaegeuk Kim --- drivers/

Re: [dm-devel] [PATCH 04/19] Revert "multipath-tools: discard san_path_err_XXX feature"

2019-01-02 Thread Muneendra Kumar M
Hi Martin, I completely agree with you as we cannot derive a direct formula behind these two unless we don't know the IOPS on a particular path. As the IOPS in both the cases are different during the detection of Shaky path. In marginal_path_XX case the IOPS are fixed i.e 100 (at a sample rate of

Re: [dm-devel] [PATCH 04/19] Revert "multipath-tools: discard san_path_err_XXX feature"

2019-01-02 Thread Muneendra Kumar M
Hi Martin, The san_path_err_XX feature was added by me and pushed to the upstream. And this feature was driven from Brocade Customer Feedback. And the below link will give the history of this where couple of discussions went before we started this feature. https://www.redhat.com/archives/dm-deve

Re: [dm-devel] dm: give req_size precisely given by user

2019-01-02 Thread Jaegeuk Kim
On 12/18, Mike Snitzer wrote: > On Tue, Dec 18 2018 at 12:45pm -0500, > Jens Axboe wrote: > > > On 12/18/18 10:25 AM, Jaegeuk Kim wrote: > > > This patch makes dm be aware of io_pages to assign sane req_size for > > > reads. > > > > Reviewed-by: Jens Axboe > > > > I've applied this, see: > h

Re: [dm-devel] [PATCH 04/19] Revert "multipath-tools: discard san_path_err_XXX feature"

2019-01-02 Thread Muneendra Kumar M
Hi Martin, In one of the patch "[PATCH 00/19] san_path_err & multipath ANA support" you have mentioned that san_path_err_XXX has some merits over marginal_path_err_XXX. Is this understanding correct if so could you please explain the scenario in which use case this was better. I can say Margin

Re: [dm-devel] [PATCH 04/19] Revert "multipath-tools: discard san_path_err_XXX feature"

2019-01-02 Thread Muneendra Kumar M
Hi Martin, Please find my replies below. >Hi Muneedra, > The san_path_err_XX feature was added by me and pushed to the > upstream. > And this feature was driven from Brocade Customer Feedback. > > And the below link will give the history of this where couple of > discussions went before we start

Re: [dm-devel] [PATCH] dm: give req_size precisely given by user

2019-01-02 Thread Sasha Levin
Hi, [This is an automated email] This commit has been processed because it contains a "Fixes:" tag, fixing commit: 9491ae4aade6 mm: don't cap request size based on read-ahead setting. The bot has tested the following trees: v4.19.10, v4.14.89, v4.19.10: Failed to apply! Possible dependencies:

Re: [dm-devel] [git pull] device mapper changes for 4.21

2019-01-02 Thread pr-tracker-bot
The pull request you sent on Thu, 27 Dec 2018 11:09:44 -0500: > git://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git > tags/for-4.21/dm-changes has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/4ed7bdc1eb4c82cf4bfdf6a94dd36fd695f6f387 Thank you! --