Re: add more bio helper

2025-04-24 Thread Kent Overstreet
On Thu, Apr 24, 2025 at 10:37:40AM +0200, Christoph Hellwig wrote: > On Wed, Apr 23, 2025 at 02:02:11PM -0400, Kent Overstreet wrote: > > Allocating your own bio doesn't allow you to safely exceed the > > BIO_MAX_VECS limit - there's places in the io path that need to bounce, > > and they all use b

Re: add more bio helper

2025-04-24 Thread Christoph Hellwig
On Wed, Apr 23, 2025 at 02:02:11PM -0400, Kent Overstreet wrote: > Allocating your own bio doesn't allow you to safely exceed the > BIO_MAX_VECS limit - there's places in the io path that need to bounce, > and they all use biosets. Yes. Another reason not to do it, which I don't want to anyway.

Re: add more bio helper

2025-04-23 Thread Kent Overstreet
On Wed, Apr 23, 2025 at 06:07:33PM +0200, Christoph Hellwig wrote: > On Wed, Apr 23, 2025 at 06:37:41AM -0400, Kent Overstreet wrote: > > > It also don't support bio chaining or error handling and requires a > > > single bio that is guaranteed to fit the required number of vectors. > > > > Why wou

Re: add more bio helper

2025-04-23 Thread Christoph Hellwig
On Wed, Apr 23, 2025 at 06:37:41AM -0400, Kent Overstreet wrote: > > It also don't support bio chaining or error handling and requires a > > single bio that is guaranteed to fit the required number of vectors. > > Why would bio chaining ever be required? The caller allocates both the > buf and the

Re: add more bio helper

2025-04-23 Thread Kent Overstreet
On Wed, Apr 23, 2025 at 11:36:21AM +0200, Christoph Hellwig wrote: > On Tue, Apr 22, 2025 at 10:47:03AM -0400, Kent Overstreet wrote: > > On Tue, Apr 22, 2025 at 04:26:01PM +0200, Christoph Hellwig wrote: > > > Hi all, > > > > > > this series adds more block layer helpers to remove boilerplate cod

Re: add more bio helper

2025-04-23 Thread Christoph Hellwig
On Tue, Apr 22, 2025 at 10:47:03AM -0400, Kent Overstreet wrote: > On Tue, Apr 22, 2025 at 04:26:01PM +0200, Christoph Hellwig wrote: > > Hi all, > > > > this series adds more block layer helpers to remove boilerplate code when > > adding memory to a bio or to even do the entire synchronous I/O. >

Re: add more bio helper

2025-04-22 Thread Kent Overstreet
On Tue, Apr 22, 2025 at 04:26:01PM +0200, Christoph Hellwig wrote: > Hi all, > > this series adds more block layer helpers to remove boilerplate code when > adding memory to a bio or to even do the entire synchronous I/O. > > The main aim is to avoid having to convert to a struct page in the call

add more bio helper

2025-04-22 Thread Christoph Hellwig
Hi all, this series adds more block layer helpers to remove boilerplate code when adding memory to a bio or to even do the entire synchronous I/O. The main aim is to avoid having to convert to a struct page in the caller when adding kernel direct mapping or vmalloc memory. Diffstat: block/bio.c