Re: [PATCH 6/8] net: tcp: tsq: Convert from tasklet to BH workqueue

2025-05-27 Thread Jason Xing
On Wed, May 28, 2025 at 2:55 AM Tejun Heo wrote: > > Hello, > > On Sun, May 25, 2025 at 11:51:55AM +0800, Jason Xing wrote: > > Sorry to revive the old thread! I noticed this change because I've > > been doing an investigation around TSQ recently. I'm very cautious > > about the change in the core

Re: [PATCH 6/8] net: tcp: tsq: Convert from tasklet to BH workqueue

2025-05-27 Thread Tejun Heo
Hello, On Sun, May 25, 2025 at 11:51:55AM +0800, Jason Xing wrote: > Sorry to revive the old thread! I noticed this change because I've > been doing an investigation around TSQ recently. I'm very cautious > about the change in the core/sensitive part of the networking area > because it might affec

Re: [PATCH 6/8] net: tcp: tsq: Convert from tasklet to BH workqueue

2025-05-24 Thread Jason Xing
On Tue, Jan 30, 2024 at 5:24 PM Tejun Heo wrote: > > The only generic interface to execute asynchronously in the BH context is > tasklet; however, it's marked deprecated and has some design flaws. To > replace tasklets, BH workqueue support was recently added. A BH workqueue > behaves similarly to

Re: [PATCH 6/8] net: tcp: tsq: Convert from tasklet to BH workqueue

2024-02-16 Thread Tejun Heo
Hello, Eric. How have you been? On Fri, Feb 16, 2024 at 09:23:00AM +0100, Eric Dumazet wrote: ... > TSQ matters for high BDP, and is very time sensitive. > > Things like slow TX completions (firing from napi poll, BH context) > can hurt TSQ. > > If we add on top of these slow TX completions, an

Re: [PATCH 6/8] net: tcp: tsq: Convert from tasklet to BH workqueue

2024-02-16 Thread David Wei
On 2024-02-16 01:23, Eric Dumazet wrote: > !---| > This Message Is From an External Sender > > |---! > > On Fri, Feb 16, 2024 at 6:31 AM Tejun Heo wrote: >> >> Hello,

Re: [PATCH 6/8] net: tcp: tsq: Convert from tasklet to BH workqueue

2024-02-16 Thread Eric Dumazet
On Fri, Feb 16, 2024 at 6:31 AM Tejun Heo wrote: > > Hello, > > On Mon, Jan 29, 2024 at 11:11:53PM -1000, Tejun Heo wrote: > > The only generic interface to execute asynchronously in the BH context is > > tasklet; however, it's marked deprecated and has some design flaws. To > > replace tasklets,

Re: [PATCH 6/8] net: tcp: tsq: Convert from tasklet to BH workqueue

2024-02-15 Thread Tejun Heo
Hello, On Mon, Jan 29, 2024 at 11:11:53PM -1000, Tejun Heo wrote: > The only generic interface to execute asynchronously in the BH context is > tasklet; however, it's marked deprecated and has some design flaws. To > replace tasklets, BH workqueue support was recently added. A BH workqueue > behav