Re: [PATCH 4/6] libmpathutil: silence compiler warning in vector_del_slot()

2025-05-07 Thread Martin Wilck
On Tue, 2025-05-06 at 18:01 -0400, Benjamin Marzinski wrote: > On Mon, May 05, 2025 at 06:29:56PM +0200, Martin Wilck wrote: > > Try to silence a gcc warning. Also, replace the wrong-looking > > VECTOR_DEFAULT_SIZE by 1 (after all, we've just deleted a single > > element). > > > > Found by Fedora'

Re: [PATCH 4/6] libmpathutil: silence compiler warning in vector_del_slot()

2025-05-06 Thread Benjamin Marzinski
On Mon, May 05, 2025 at 06:29:56PM +0200, Martin Wilck wrote: > Try to silence a gcc warning. Also, replace the wrong-looking > VECTOR_DEFAULT_SIZE by 1 (after all, we've just deleted a single > element). > > Found by Fedora's static analysis [1]. > > [1] > https://openscanhub.fedoraproject.org/

Re: [PATCH 4/6] libmpathutil: silence compiler warning in vector_del_slot()

2025-05-06 Thread Benjamin Marzinski
On Mon, May 05, 2025 at 06:29:56PM +0200, Martin Wilck wrote: > Try to silence a gcc warning. Also, replace the wrong-looking > VECTOR_DEFAULT_SIZE by 1 (after all, we've just deleted a single > element). I agree that VECTOR_DEFAULT_SIZE is pointless. But we shoud also stop adding VECTOR_DEFAULT_S