Re: [PATCH 15/19] xfs: simplify xfs_buf_submit_bio

2025-05-02 Thread Christoph Hellwig
On Thu, May 01, 2025 at 12:51:03PM -0700, Darrick J. Wong wrote: > > + bio = bio_alloc(bp->b_target->bt_bdev, nr_vecs, xfs_buf_bio_op(bp), > > + GFP_NOIO); > > + if (is_vmalloc_addr(bp->b_addr)) > > + bio_add_vmalloc(bio, bp->b_addr, len); > > I wonder, do we need a

Re: [PATCH 15/19] xfs: simplify xfs_buf_submit_bio

2025-05-01 Thread Darrick J. Wong
On Wed, Apr 30, 2025 at 04:21:45PM -0500, Christoph Hellwig wrote: > Convert the __bio_add_page(..., virt_to_page(), ...) pattern to the > bio_add_virt_nofail helper implementing it and use bio_add_vmalloc > to insulate xfs from the details of adding vmalloc memory to a bio. > > Signed-off-by: Chr

Re: [PATCH 15/19] xfs: simplify xfs_buf_submit_bio

2025-05-01 Thread Damien Le Moal
On 5/1/25 06:21, Christoph Hellwig wrote: > Convert the __bio_add_page(..., virt_to_page(), ...) pattern to the > bio_add_virt_nofail helper implementing it and use bio_add_vmalloc > to insulate xfs from the details of adding vmalloc memory to a bio. > > Signed-off-by: Christoph Hellwig Looks go