Re: [PATCH 02/17] block: add a bdev_rw_virt helper

2025-04-29 Thread Johannes Thumshirn
With the typo fixes addressed: Reviewed-by: Johannes Thumshirn

Re: [PATCH 02/17] block: add a bdev_rw_virt helper

2025-04-23 Thread John Garry
On 22/04/2025 15:26, Christoph Hellwig wrote: + * @sector:sector to accasse nit: typo in accasse + * @data: data to read/write + * @len: length to read/write + * @op:operation (e.g. REQ_OP_READ/REQ_OP_WRITE) + * + * Performs synchronous I/O to @bdev for @data/@l

Re: [PATCH 02/17] block: add a bdev_rw_virt helper

2025-04-23 Thread Damien Le Moal
On 4/22/25 23:26, Christoph Hellwig wrote: > Add a helper to perform synchronous I/O on a kernel direct map range. > Currently this is implemented in various places in usually not very > efficient ways, so provide a generic helper instead. > > Signed-off-by: Christoph Hellwig > --- > block/bio.c

Re: [PATCH 02/17] block: add a bdev_rw_virt helper

2025-04-23 Thread Christoph Hellwig
On Wed, Apr 23, 2025 at 08:07:19AM +0200, Hannes Reinecke wrote: >> +int submit_bio_wait(struct bio *bio); >> +int bdev_rw_virt(struct block_device *bdev, sector_t sector, void *data, >> +size_t len, enum req_op op); >> + >> int bio_iov_iter_get_pages(struct bio *bio, struct iov_ite

Re: [PATCH 02/17] block: add a bdev_rw_virt helper

2025-04-22 Thread Hannes Reinecke
On 4/22/25 16:26, Christoph Hellwig wrote: Add a helper to perform synchronous I/O on a kernel direct map range. Currently this is implemented in various places in usually not very efficient ways, so provide a generic helper instead. Signed-off-by: Christoph Hellwig --- block/bio.c |