Re: [PATCH] dm: add missing unlock on in dm_keyslot_evict()

2025-05-05 Thread Benjamin Marzinski
On Sun, May 04, 2025 at 01:30:42PM +0200, Mikulas Patocka wrote: > > > On Wed, 30 Apr 2025, Mikulas Patocka wrote: > > > Ben already tried to fix it in dm_blk_report_zones (see the linux-dm git, > > for-next branch) - but his fix is incorrect because the "if" condition for > > dm_get_live_tabl

Re: [PATCH] dm: add missing unlock on in dm_keyslot_evict()

2025-05-04 Thread Mikulas Patocka
On Wed, 30 Apr 2025, Mikulas Patocka wrote: > Ben already tried to fix it in dm_blk_report_zones (see the linux-dm git, > for-next branch) - but his fix is incorrect because the "if" condition for > dm_get_live_table and dm_put_live_table differs. I'll update his patch to > fix this mismatch

Re: [PATCH] dm: add missing unlock on in dm_keyslot_evict()

2025-04-30 Thread Mikulas Patocka
On Wed, 30 Apr 2025, Dan Carpenter wrote: > On Wed, Apr 30, 2025 at 09:50:37AM -0700, Eric Biggers wrote: > > On Wed, Apr 30, 2025 at 11:05:54AM +0300, Dan Carpenter wrote: > > > We need to call dm_put_live_table() even if dm_get_live_table() returns > > > NULL. > > > > > > Fixes: 9355a9eb21a5

Re: [PATCH] dm: add missing unlock on in dm_keyslot_evict()

2025-04-30 Thread Dan Carpenter
On Wed, Apr 30, 2025 at 09:50:37AM -0700, Eric Biggers wrote: > On Wed, Apr 30, 2025 at 11:05:54AM +0300, Dan Carpenter wrote: > > We need to call dm_put_live_table() even if dm_get_live_table() returns > > NULL. > > > > Fixes: 9355a9eb21a5 ("dm: support key eviction from keyslot managers of > >

Re: [PATCH] dm: add missing unlock on in dm_keyslot_evict()

2025-04-30 Thread Eric Biggers
On Wed, Apr 30, 2025 at 11:05:54AM +0300, Dan Carpenter wrote: > We need to call dm_put_live_table() even if dm_get_live_table() returns > NULL. > > Fixes: 9355a9eb21a5 ("dm: support key eviction from keyslot managers of > underlying devices") > Signed-off-by: Dan Carpenter > --- > drivers/md/d