Re: [git pull] device mapper fixes for 6.7-rc2

2023-11-20 Thread Kirill A. Shutemov
On Mon, Nov 20, 2023 at 09:40:48AM -0800, Andrew Morton wrote: > On Mon, 20 Nov 2023 09:36:46 -0800 Linus Torvalds > wrote: > > > On Mon, 20 Nov 2023 at 05:31, Kirill A. Shutemov > > wrote: > > > > > > NR_ORDERS defines the number of page orders supported by the page > > > allocator, ranging fr

Re: [git pull] device mapper fixes for 6.7-rc2

2023-11-20 Thread Andrew Morton
On Mon, 20 Nov 2023 09:36:46 -0800 Linus Torvalds wrote: > On Mon, 20 Nov 2023 at 05:31, Kirill A. Shutemov > wrote: > > > > NR_ORDERS defines the number of page orders supported by the page > > allocator, ranging from 0 to MAX_ORDER, MAX_ORDER + 1 in total. > > > > NR_ORDERS assists in definin

Re: [git pull] device mapper fixes for 6.7-rc2

2023-11-20 Thread Linus Torvalds
On Mon, 20 Nov 2023 at 05:31, Kirill A. Shutemov wrote: > > NR_ORDERS defines the number of page orders supported by the page > allocator, ranging from 0 to MAX_ORDER, MAX_ORDER + 1 in total. > > NR_ORDERS assists in defining arrays of page orders and allows for more > natural iteration over them.

Re: [git pull] device mapper fixes for 6.7-rc2

2023-11-20 Thread Kirill A. Shutemov
On Sun, Nov 19, 2023 at 06:21:36PM +0300, Kirill A. Shutemov wrote: > > Oh well. Now we have places with 'MAX_ORDER + 1' instead of 'MAX_ORDER > > - 1'. I'm not seeing that it's a win, and I do think "semantic change > > after 24 years" is a loss and is going to cause problems. > > I think it wort

Re: [git pull] device mapper fixes for 6.7-rc2

2023-11-19 Thread Kirill A. Shutemov
On Sat, Nov 18, 2023 at 11:14:25AM -0800, Linus Torvalds wrote: > On Sat, 18 Nov 2023 at 10:33, Linus Torvalds > wrote: > > > > What are the alleged "number of bugs all over the kernel" that the old > > MAX_ORDER definition had? In light of the other "MAX" definitions I > > found from a second of

Re: [git pull] device mapper fixes for 6.7-rc2

2023-11-18 Thread Linus Torvalds
On Sat, 18 Nov 2023 at 10:33, Linus Torvalds wrote: > > What are the alleged "number of bugs all over the kernel" that the old > MAX_ORDER definition had? In light of the other "MAX" definitions I > found from a second of grepping, I really think the argument for that > was just wrong. Bah. I loo

Re: [git pull] device mapper fixes for 6.7-rc2

2023-11-18 Thread pr-tracker-bot
The pull request you sent on Sat, 18 Nov 2023 11:04:52 -0500: > git://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git > tags/for-6.7/dm-fixes has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/05aa69b096a089dc85391e36ccdce76961694e22 Thank you! -- De

Re: [git pull] device mapper fixes for 6.7-rc2

2023-11-18 Thread Linus Torvalds
On Sat, 18 Nov 2023 at 08:04, Mike Snitzer wrote: > > - Update DM crypt target in response to the treewide change that made > MAX_ORDER inclusive. Your fix is obviously correct, and was an unfortunate semantic conflict that I (and in my defense, apparently linux-next) missed this merge window.

[git pull] device mapper fixes for 6.7-rc2

2023-11-18 Thread Mike Snitzer
Hi Linus, The following changes since commit b85ea95d086471afb4ad062012a4d73cd328fa86: Linux 6.7-rc1 (2023-11-12 16:19:07 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git tags/for-6.7/dm-fixes for you to fetch changes