Re: [PATCH v6 0/6] block/md/dm: set chunk_sectors from stacked dev stripe size

2025-07-15 Thread Hannes Reinecke
On 7/14/25 08:13, Christoph Hellwig wrote: On Mon, Jul 14, 2025 at 03:00:57PM +0900, Damien Le Moal wrote: Agreed, it would be nice to clean that up. BUT, the chunk_sectors sysfs attribute file is reporting the zone size today. Changing that may break applications. So I am not sure if we can act

Re: [PATCH v6 0/6] block/md/dm: set chunk_sectors from stacked dev stripe size

2025-07-14 Thread Christoph Hellwig
On Mon, Jul 14, 2025 at 08:52:39AM +0100, John Garry wrote: > On 14/07/2025 06:53, Christoph Hellwig wrote: >> Now we should be able to implement the software atomic writes pretty >> easily for zoned XFS, and funnily they might actually be slightly faster >> than normal writes due to the transactio

Re: [PATCH v6 0/6] block/md/dm: set chunk_sectors from stacked dev stripe size

2025-07-14 Thread John Garry
On 14/07/2025 06:53, Christoph Hellwig wrote: Now we should be able to implement the software atomic writes pretty easily for zoned XFS, and funnily they might actually be slightly faster than normal writes due to the transaction batching. Now that we're getting reasonable test coverage we shoul

Re: [PATCH v6 0/6] block/md/dm: set chunk_sectors from stacked dev stripe size

2025-07-13 Thread Christoph Hellwig
On Mon, Jul 14, 2025 at 03:00:57PM +0900, Damien Le Moal wrote: > Agreed, it would be nice to clean that up. BUT, the chunk_sectors sysfs > attribute file is reporting the zone size today. Changing that may break > applications. So I am not sure if we can actually do that, unless the sysfs > interf

Re: [PATCH v6 0/6] block/md/dm: set chunk_sectors from stacked dev stripe size

2025-07-13 Thread Damien Le Moal
On 2025/07/14 14:53, Christoph Hellwig wrote: > On Fri, Jul 11, 2025 at 05:44:26PM +0900, Damien Le Moal wrote: >> On 7/11/25 5:09 PM, John Garry wrote: >>> This value in io_min is used to configure any atomic write limit for the >>> stacked device. The idea is that the atomic write unit max is a >

Re: [PATCH v6 0/6] block/md/dm: set chunk_sectors from stacked dev stripe size

2025-07-13 Thread Christoph Hellwig
On Fri, Jul 11, 2025 at 05:44:26PM +0900, Damien Le Moal wrote: > On 7/11/25 5:09 PM, John Garry wrote: > > This value in io_min is used to configure any atomic write limit for the > > stacked device. The idea is that the atomic write unit max is a > > power-of-2 factor of the stripe size, and the

Re: [PATCH v6 0/6] block/md/dm: set chunk_sectors from stacked dev stripe size

2025-07-11 Thread John Garry
On 11/07/2025 09:44, Damien Le Moal wrote: This series now sets chunk_sectors limit to share stripe size. Hmm... chunk_sectors for a zoned device is the zone size. So is this all safe if we are dealing with a zoned block device that also supports atomic writes ? Not that I know of any such devic

Re: [PATCH v6 0/6] block/md/dm: set chunk_sectors from stacked dev stripe size

2025-07-11 Thread Damien Le Moal
On 7/11/25 5:09 PM, John Garry wrote: > This value in io_min is used to configure any atomic write limit for the > stacked device. The idea is that the atomic write unit max is a > power-of-2 factor of the stripe size, and the stripe size is available > in io_min. > > Using io_min causes issues, a

[PATCH v6 0/6] block/md/dm: set chunk_sectors from stacked dev stripe size

2025-07-11 Thread John Garry
This value in io_min is used to configure any atomic write limit for the stacked device. The idea is that the atomic write unit max is a power-of-2 factor of the stripe size, and the stripe size is available in io_min. Using io_min causes issues, as: a. it may be mutated b. the check for io_min be