Re: [PATCH v2 4/5] md: fix is_mddev_idle()

2025-04-26 Thread Xiao Ni
On Sun, Apr 27, 2025 at 9:37 AM Yu Kuai wrote: > > Hi, > > 在 2025/04/22 14:35, Xiao Ni 写道: > >> + unsigned long last_events;/* IO event > >> timestamp */ > > Can we use another name? Because mddev has events counter. This name > > can easily be confused with that count

Re: [PATCH v2 4/5] md: fix is_mddev_idle()

2025-04-26 Thread Yu Kuai
Hi, 在 2025/04/22 14:35, Xiao Ni 写道: + unsigned long last_events;/* IO event timestamp */ Can we use another name? Because mddev has events counter. This name can easily be confused with that counter. Sorry for the late reply. Sure, how about, normal_IO_events? Th

Re: [PATCH v2 4/5] md: fix is_mddev_idle()

2025-04-21 Thread Xiao Ni
On Fri, Apr 18, 2025 at 9:17 AM Yu Kuai wrote: > > From: Yu Kuai > > If sync_speed is above speed_min, then is_mddev_idle() will be called > for each sync IO to check if the array is idle, and inflihgt sync_io > will be limited if the array is not idle. > > However, while mkfs.ext4 for a large ra

Re: [PATCH v2 4/5] md: fix is_mddev_idle()

2025-04-18 Thread Su Yue
On Sat 19 Apr 2025 at 10:00, Yu Kuai wrote: Hi, 在 2025/04/19 9:42, Su Yue 写道: On Fri 18 Apr 2025 at 09:09, Yu Kuai wrote: From: Yu Kuai If sync_speed is above speed_min, then is_mddev_idle() will be called for each sync IO to check if the array is idle, and inflihgt sync_io will be

Re: [PATCH v2 4/5] md: fix is_mddev_idle()

2025-04-18 Thread Yu Kuai
Hi, 在 2025/04/19 9:42, Su Yue 写道: On Fri 18 Apr 2025 at 09:09, Yu Kuai wrote: From: Yu Kuai If sync_speed is above speed_min, then is_mddev_idle() will be called for each sync IO to check if the array is idle, and inflihgt sync_io will be limited if the array is not idle. However, while mk

Re: [PATCH v2 4/5] md: fix is_mddev_idle()

2025-04-18 Thread Su Yue
On Fri 18 Apr 2025 at 09:09, Yu Kuai wrote: From: Yu Kuai If sync_speed is above speed_min, then is_mddev_idle() will be called for each sync IO to check if the array is idle, and inflihgt sync_io will be limited if the array is not idle. However, while mkfs.ext4 for a large raid5 array

[PATCH v2 4/5] md: fix is_mddev_idle()

2025-04-17 Thread Yu Kuai
From: Yu Kuai If sync_speed is above speed_min, then is_mddev_idle() will be called for each sync IO to check if the array is idle, and inflihgt sync_io will be limited if the array is not idle. However, while mkfs.ext4 for a large raid5 array while recovery is in progress, it's found that sync_