Re: [PATCH v2 1/5] block: cleanup and export bdev IO inflight APIs

2025-04-21 Thread Christoph Hellwig
On Mon, Apr 21, 2025 at 09:13:57PM +0800, Yu Kuai wrote: > > I'm not sure why this is needed or related, or even what additional > > distinction is added here. > > Because for rq-based device, there are two different stage, > blk_account_io_start() while allocating new rq, and > blk_mq_start_reque

Re: [PATCH v2 1/5] block: cleanup and export bdev IO inflight APIs

2025-04-21 Thread Yu Kuai
Hi, 在 2025/04/21 19:59, Christoph Hellwig 写道: On Fri, Apr 18, 2025 at 09:09:37AM +0800, Yu Kuai wrote: - remove unused blk_mq_in_flight That should probably be a separate patch. ok - rename blk_mq_in_flight_rw to blk_mq_count_in_driver_rw, to distinguish from bdev_count_inflight_rw.

Re: [PATCH v2 1/5] block: cleanup and export bdev IO inflight APIs

2025-04-21 Thread Christoph Hellwig
On Fri, Apr 18, 2025 at 09:09:37AM +0800, Yu Kuai wrote: > - remove unused blk_mq_in_flight That should probably be a separate patch. > - rename blk_mq_in_flight_rw to blk_mq_count_in_driver_rw, to distinguish > from bdev_count_inflight_rw. I'm not sure why this is needed or related, or even w

[PATCH v2 1/5] block: cleanup and export bdev IO inflight APIs

2025-04-17 Thread Yu Kuai
From: Yu Kuai - rename part_in_{flight, flight_rw} and to bdev_count_{inflight, inflight_rw}. - export bdev_count_inflight_rw, to fix a problem in mdraid that foreground IO can be starved by background sync IO in later patches. - reuse bdev_count_inflight_rw for bdev_count_inflight, also add