Re: [PATCH 11/15] limpathpersist: Handle changing key corner case

2025-07-14 Thread Martin Wilck
On Mon, 2025-07-14 at 12:59 -0400, Benjamin Marzinski wrote: > On Fri, Jul 11, 2025 at 04:11:46PM +0200, Martin Wilck wrote: > > On Fri, 2025-07-11 at 14:15 +0200, Martin Wilck wrote: > > > > > > It's getting so awkward that we might as well just use memset. > > Yeah. picking a member from one o

Re: [PATCH 11/15] limpathpersist: Handle changing key corner case

2025-07-14 Thread Benjamin Marzinski
On Fri, Jul 11, 2025 at 04:11:46PM +0200, Martin Wilck wrote: > On Fri, 2025-07-11 at 14:15 +0200, Martin Wilck wrote: > > On Thu, 2025-07-10 at 14:10 -0400, Benjamin Marzinski wrote: > > > When you change the reservation key of a registered multipath > > > device, > > > some of paths might be down

Re: [PATCH 11/15] limpathpersist: Handle changing key corner case

2025-07-11 Thread Martin Wilck
On Fri, 2025-07-11 at 14:15 +0200, Martin Wilck wrote: > On Thu, 2025-07-10 at 14:10 -0400, Benjamin Marzinski wrote: > > When you change the reservation key of a registered multipath > > device, > > some of paths might be down or even deleted since you originally > > [...] > > > > Signed-off-by:

Re: [PATCH 11/15] limpathpersist: Handle changing key corner case

2025-07-11 Thread Martin Wilck
On Thu, 2025-07-10 at 14:10 -0400, Benjamin Marzinski wrote: > When you change the reservation key of a registered multipath device, > some of paths might be down or even deleted since you originally [...] > > Signed-off-by: Benjamin Marzinski This is not a full review, just feedback about a fa

[PATCH 11/15] limpathpersist: Handle changing key corner case

2025-07-10 Thread Benjamin Marzinski
When you change the reservation key of a registered multipath device, some of paths might be down or even deleted since you originally registered the key. libmpathpersist won't be able to change these registrations. This can be a problem if the path that is down is holding the reservation. Other no