Re: [PATCH 04/17] block: remove the q argument from blk_rq_map_kern

2025-04-29 Thread hch
On Tue, Apr 29, 2025 at 11:24:55AM +, Johannes Thumshirn wrote: > > Good cleanup. I always wondered why we need to have it. > > Because we used to call 'bio_add_pc_page()' in e.g. bio_map_kern()' > which took a request_queue. But that got changed in 6aeb4f8364806 > ("block: remove bio_add_pc

Re: [PATCH 04/17] block: remove the q argument from blk_rq_map_kern

2025-04-29 Thread Johannes Thumshirn
On 23.04.25 08:10, Hannes Reinecke wrote: > On 4/22/25 16:26, Christoph Hellwig wrote: >> Remove the q argument from blk_rq_map_kern and the internal helpers >> called by it as the queue can trivially be derived from the request. >> >> Signed-off-by: Christoph Hellwig >> --- >>block/blk-map.c

Re: [PATCH 04/17] block: remove the q argument from blk_rq_map_kern

2025-04-23 Thread Damien Le Moal
On 4/22/25 23:26, Christoph Hellwig wrote: > Remove the q argument from blk_rq_map_kern and the internal helpers > called by it as the queue can trivially be derived from the request. > > Signed-off-by: Christoph Hellwig Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital Research

Re: [PATCH 04/17] block: remove the q argument from blk_rq_map_kern

2025-04-22 Thread Hannes Reinecke
On 4/22/25 16:26, Christoph Hellwig wrote: Remove the q argument from blk_rq_map_kern and the internal helpers called by it as the queue can trivially be derived from the request. Signed-off-by: Christoph Hellwig --- block/blk-map.c| 24 ++-- drivers/block/pkt

[PATCH 04/17] block: remove the q argument from blk_rq_map_kern

2025-04-22 Thread Christoph Hellwig
Remove the q argument from blk_rq_map_kern and the internal helpers called by it as the queue can trivially be derived from the request. Signed-off-by: Christoph Hellwig --- block/blk-map.c| 24 ++-- drivers/block/pktcdvd.c| 2 +- drivers/block/ublk_drv.c |