Re: [PATCH] md/raid1,raid10: don't pass down the REQ_RAHEAD flag

2025-05-19 Thread Yu Kuai
Hi, 在 2025/05/19 20:34, Yu Kuai 写道: Hi, 在 2025/05/19 20:05, Mikulas Patocka 写道: On Mon, 19 May 2025, Yu Kuai wrote: Hi, 在 2025/05/19 19:19, Yu Kuai 写道: The commit e879a0d9cb08 ("md/raid1,raid10: don't ignore IO flags") breaks the lvm2 test shell/lvcreate-large-raid.sh. The commit changes

Re: [PATCH] md/raid1,raid10: don't pass down the REQ_RAHEAD flag

2025-05-19 Thread Yu Kuai
Hi, 在 2025/05/19 20:05, Mikulas Patocka 写道: On Mon, 19 May 2025, Yu Kuai wrote: Hi, 在 2025/05/19 19:19, Yu Kuai 写道: The commit e879a0d9cb08 ("md/raid1,raid10: don't ignore IO flags") breaks the lvm2 test shell/lvcreate-large-raid.sh. The commit changes raid1 and raid10 to pass down all the

Re: [PATCH] md/raid1,raid10: don't pass down the REQ_RAHEAD flag

2025-05-19 Thread Mikulas Patocka
On Mon, 19 May 2025, Yu Kuai wrote: > Hi, > > Please ignore the last reply, I misunderstand your commit message, I > thought you said dm-raid, actually you said mdraid, and it's correct, > if read_bio faild raid1/10 will set badblocks which is not expected. > > Then for reada head IO, I still

Re: [PATCH] md/raid1,raid10: don't pass down the REQ_RAHEAD flag

2025-05-19 Thread Mikulas Patocka
On Mon, 19 May 2025, Yu Kuai wrote: > Hi, > > 在 2025/05/19 19:19, Yu Kuai 写道: > > > The commit e879a0d9cb08 ("md/raid1,raid10: don't ignore IO flags") breaks > > > the lvm2 test shell/lvcreate-large-raid.sh. The commit changes raid1 and > > > raid10 to pass down all the flags from the incoming

Re: [PATCH] md/raid1,raid10: don't pass down the REQ_RAHEAD flag

2025-05-19 Thread Yu Kuai
Hi, 在 2025/05/19 19:19, Yu Kuai 写道: The commit e879a0d9cb08 ("md/raid1,raid10: don't ignore IO flags") breaks the lvm2 test shell/lvcreate-large-raid.sh. The commit changes raid1 and raid10 to pass down all the flags from the incoming bio. The problem is when we pass down the REQ_RAHEAD flag - b

Re: [PATCH] md/raid1,raid10: don't pass down the REQ_RAHEAD flag

2025-05-19 Thread Yu Kuai
Hi, 在 2025/05/19 18:09, Mikulas Patocka 写道: The commit e879a0d9cb08 ("md/raid1,raid10: don't ignore IO flags") breaks the lvm2 test shell/lvcreate-large-raid.sh. The commit changes raid1 and raid10 to pass down all the flags from the incoming bio. The problem is when we pass down the REQ_RAHEAD

[PATCH] md/raid1,raid10: don't pass down the REQ_RAHEAD flag

2025-05-19 Thread Mikulas Patocka
The commit e879a0d9cb08 ("md/raid1,raid10: don't ignore IO flags") breaks the lvm2 test shell/lvcreate-large-raid.sh. The commit changes raid1 and raid10 to pass down all the flags from the incoming bio. The problem is when we pass down the REQ_RAHEAD flag - bios with this flag may fail anytime and