Re: [PATCH] dm-delay: Prevent zoned write reordering on suspend

2025-04-09 Thread Damien Le Moal
On 4/10/25 1:33 PM, Damien Le Moal wrote: > When a dm-delay devie is being suspended, the .presuspend() operation is > first executed (delay_presuspend()) to immediately issue all the BIOs > present in the delayed list of the device and also sets the device > may_delay boolean to false. At the same

[PATCH] dm-delay: Prevent zoned write reordering on suspend

2025-04-09 Thread Damien Le Moal
When a dm-delay devie is being suspended, the .presuspend() operation is first executed (delay_presuspend()) to immediately issue all the BIOs present in the delayed list of the device and also sets the device may_delay boolean to false. At the same time, any new BIO is issued to the device will no

Re: [RFC PATCH -next v3 01/10] block: introduce BLK_FEAT_WRITE_ZEROES_UNMAP to queue limits features

2025-04-09 Thread Zhang Yi
On 2025/4/9 18:31, Christoph Hellwig wrote: > On Tue, Mar 18, 2025 at 03:35:36PM +0800, Zhang Yi wrote: >> From: Zhang Yi >> >> Currently, disks primarily implement the write zeroes command (aka >> REQ_OP_WRITE_ZEROES) through two mechanisms: the first involves >> physically writing zeros to the d

[PATCH] block: Export __blk_flush_plug to modules

2025-04-09 Thread LongPing Wei
Fix the compile error when dm-bufio is built as a module. 1. dm-bufio module use blk_flush_plug(); 2. blk_flush_plug is an inline function and it calls __blk_flush_plug. Signed-off-by: LongPing Wei --- block/blk-core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/blk-core.c b/block

Re: [PATCH v3 5/6] dm: limit swapping tables for devices with zone write plugs

2025-04-09 Thread Benjamin Marzinski
On Wed, Apr 09, 2025 at 03:20:31PM +0900, Damien Le Moal wrote: > On 4/9/25 8:51 AM, Benjamin Marzinski wrote: > > dm_revalidate_zones() only allowed new or previously unzoned devices to > > call blk_revalidate_disk_zones(). If the device was already zoned, > > disk->nr_zones would always equal md-

Re: [PATCH v3 4/6] dm: fix dm_blk_report_zones

2025-04-09 Thread Benjamin Marzinski
On Wed, Apr 09, 2025 at 03:02:58PM +0900, Damien Le Moal wrote: > On 4/9/25 8:51 AM, Benjamin Marzinski wrote: > > If dm_get_live_table() returned NULL, dm_put_live_table() was never > > called. Also, it is possible that md->zone_revalidate_map will change > > while calling this function. Only read

Re: [RFC PATCH -next v3 09/10] block: factor out common part in blkdev_fallocate()

2025-04-09 Thread Christoph Hellwig
On Wed, Apr 09, 2025 at 12:36:29PM +0200, Christoph Hellwig wrote: > Looks good: > > Reviewed-by: Christoph Hellwig .. although this really should go before the previous patch.

Re: [RFC PATCH -next v3 07/10] fs: introduce FALLOC_FL_WRITE_ZEROES to fallocate

2025-04-09 Thread Christian Brauner
On Wed, Apr 09, 2025 at 12:35:48PM +0200, Christoph Hellwig wrote: > On Tue, Mar 18, 2025 at 03:35:42PM +0800, Zhang Yi wrote: > > Users can check the disk support of unmap write zeroes command by > > querying: > > > > /sys/block//queue/write_zeroes_unmap > > No, that is not in any way a good

Re: [PATCH RFC v2 00/14] md: introduce a new lockless bitmap

2025-04-09 Thread Yu Kuai
Hi, 在 2025/04/09 16:32, Christoph Hellwig 写道: On Sat, Mar 29, 2025 at 09:11:13AM +0800, Yu Kuai wrote: The purpose here is to hide the low level bitmap IO implementation to the API disk->submit_bio(), and the bitmap IO can be converted to buffer IO to the bdev_file. This is the easiest way that

Re: [RFC PATCH -next v3 07/10] fs: introduce FALLOC_FL_WRITE_ZEROES to fallocate

2025-04-09 Thread Christoph Hellwig
On Tue, Mar 18, 2025 at 03:35:42PM +0800, Zhang Yi wrote: > Users can check the disk support of unmap write zeroes command by > querying: > > /sys/block//queue/write_zeroes_unmap No, that is not in any way a good user interface. Users need to be able to query this on a per-file basis. > Fin

Re: [RFC PATCH -next v3 09/10] block: factor out common part in blkdev_fallocate()

2025-04-09 Thread Christoph Hellwig
Looks good: Reviewed-by: Christoph Hellwig

Re: [RFC PATCH -next v3 04/10] nvmet: set WZDS and DRB if device supports BLK_FEAT_WRITE_ZEROES_UNMAP

2025-04-09 Thread Christoph Hellwig
On Tue, Mar 18, 2025 at 03:35:39PM +0800, Zhang Yi wrote: > diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h > index 5d280c7fba65..836738ab1fa6 100644 > --- a/include/linux/blkdev.h > +++ b/include/linux/blkdev.h > @@ -1344,6 +1344,11 @@ static inline unsigned int > bdev_write_zeroes_s

Re: [RFC PATCH -next v3 01/10] block: introduce BLK_FEAT_WRITE_ZEROES_UNMAP to queue limits features

2025-04-09 Thread Christoph Hellwig
On Tue, Mar 18, 2025 at 03:35:36PM +0800, Zhang Yi wrote: > From: Zhang Yi > > Currently, disks primarily implement the write zeroes command (aka > REQ_OP_WRITE_ZEROES) through two mechanisms: the first involves > physically writing zeros to the disk media (e.g., HDDs), while the > second perform

Re: [PATCH RFC v2 00/14] md: introduce a new lockless bitmap

2025-04-09 Thread Christoph Hellwig
On Wed, Apr 09, 2025 at 05:27:11PM +0800, Yu Kuai wrote: >> For that you'd be much better of just creating your own trivial >> file_system_type with an inode fully controlled by your driver >> that has a trivial set of address_space ops instead of oddly >> mixing with the block layer. > > Yes, this

Re: [PATCH RFC v2 00/14] md: introduce a new lockless bitmap

2025-04-09 Thread Christoph Hellwig
On Sat, Mar 29, 2025 at 09:11:13AM +0800, Yu Kuai wrote: > The purpose here is to hide the low level bitmap IO implementation to > the API disk->submit_bio(), and the bitmap IO can be converted to buffer > IO to the bdev_file. This is the easiest way that I can think of to > resue the pagecache, wi