Re: [PATCH] dm-verity: restart or panic on an I/O error

2024-09-24 Thread Milan Broz
On 9/25/24 8:09 AM, Maxim Suhanov wrote: Hello. This is a very strange reasoning. I can say that restarting on an IO error (that can happen in normal situations) could cause another security issue, such as DoS. EIO is not a data integrity error; it can happen even higher in the storage stack...

Re: [PATCH] dm-verity: restart or panic on an I/O error

2024-09-24 Thread Maxim Suhanov
Hello. > This is a very strange reasoning. I can say that restarting on an IO error > (that can happen in normal situations) could cause another security issue, > such as DoS. EIO is not a data integrity error; it can happen even higher > in the storage stack... and the application should handle i

Re: [PATCH] dm-verity: restart or panic on an I/O error

2024-09-24 Thread Milan Broz
On 9/24/24 8:36 PM, Mikulas Patocka wrote: On Tue, 24 Sep 2024, Akilesh Kailash wrote: On Tue, Sep 24, 2024 at 10:44 AM Sami Tolvanen wrote: Hi Mikulas, On Tue, Sep 24, 2024 at 6:18 AM Mikulas Patocka wrote: Maxim Suhanov reported that dm-verity doesn't crash if an I/O error happens. In

[PATCH] multipath-tools: hwtable housekeeping

2024-09-24 Thread Xose Vazquez Perez
Update some descriptions. And limit the Dorado regex, because "Dorado "is used as a generic brand by Huawei. = HUASY Dorado2100 HUAWEI Dorado2100 HUAWEI Dorado2100 G2 HUASY Dorado5100 HUAWEI Dorado5100 = Cc: Martin Wilck Cc: Benjamin Marzins

Re: [PATCH] dm-verity: restart or panic on an I/O error

2024-09-24 Thread Eric Biggers
On Tue, Sep 24, 2024 at 03:18:29PM +0200, Mikulas Patocka wrote: > Maxim Suhanov reported that dm-verity doesn't crash if an I/O error > happens. In theory, this could be used to subvert security, because an > attacker can create sectors that return error with the Write Uncorrectable > command.

Re: [PATCH v2 1/3] dm-inlinecrypt: Add inline encryption support

2024-09-24 Thread Eric Biggers
On Tue, Sep 24, 2024 at 12:44:53AM -0700, Christoph Hellwig wrote: > On Sat, Sep 21, 2024 at 11:55:19AM -0700, Eric Biggers wrote: > > (https://android.googlesource.com/kernel/common/+/refs/heads/android-mainline/drivers/md/dm-default-key.c), > > and I've been looking for the best way to get the fu

Re: [PATCH] dm verity: fallback to platform keyring also if key in trusted keyring is rejected

2024-09-24 Thread Eric Biggers
On Wed, Sep 25, 2024 at 12:36:01AM +0300, Jarkko Sakkinen wrote: > On Tue Sep 24, 2024 at 9:27 PM EEST, Mikulas Patocka wrote: > > > > > > On Tue, 24 Sep 2024, Jarkko Sakkinen wrote: > > > > > On Mon Sep 23, 2024 at 5:04 PM EEST, Mikulas Patocka wrote: > > > > > > > > > > > > On Sun, 22 Sep 2024, l

Re: [PATCH] dm verity: fallback to platform keyring also if key in trusted keyring is rejected

2024-09-24 Thread Jarkko Sakkinen
On Tue Sep 24, 2024 at 9:27 PM EEST, Mikulas Patocka wrote: > > > On Tue, 24 Sep 2024, Jarkko Sakkinen wrote: > > > On Mon Sep 23, 2024 at 5:04 PM EEST, Mikulas Patocka wrote: > > > > > > > > > On Sun, 22 Sep 2024, luca.bocca...@gmail.com wrote: > > > > > > > From: Luca Boccassi > > > > > > > > I

Re: [PATCH v1] md: Correct typos in multiple comments across various files

2024-09-24 Thread Song Liu
Hi Mikulas, On Tue, Sep 24, 2024 at 6:30 AM Mikulas Patocka wrote: > > Hi > > I've applied the device mapper part of the patch. Would you mind taking the whole patch instead? You can add Acked-by: Song Liu Thanks, Song

Re: [PATCH] dm-verity: restart or panic on an I/O error

2024-09-24 Thread Akilesh Kailash
On Tue, Sep 24, 2024 at 11:45 AM Mikulas Patocka wrote: > > > > On Tue, 24 Sep 2024, Akilesh Kailash wrote: > > > On Tue, Sep 24, 2024 at 10:44 AM Sami Tolvanen > > wrote: > > > > > > Hi Mikulas, > > > > > > On Tue, Sep 24, 2024 at 6:18 AM Mikulas Patocka > > > wrote: > > > > > > > > Maxim Suh

Re: [PATCH] dm-verity: restart or panic on an I/O error

2024-09-24 Thread Mikulas Patocka
On Tue, 24 Sep 2024, Akilesh Kailash wrote: > On Tue, Sep 24, 2024 at 10:44 AM Sami Tolvanen > wrote: > > > > Hi Mikulas, > > > > On Tue, Sep 24, 2024 at 6:18 AM Mikulas Patocka wrote: > > > > > > Maxim Suhanov reported that dm-verity doesn't crash if an I/O error > > > happens. In theory, th

Re: [PATCH] dm verity: fallback to platform keyring also if key in trusted keyring is rejected

2024-09-24 Thread Mikulas Patocka
On Tue, 24 Sep 2024, Jarkko Sakkinen wrote: > On Mon Sep 23, 2024 at 5:04 PM EEST, Mikulas Patocka wrote: > > > > > > On Sun, 22 Sep 2024, luca.bocca...@gmail.com wrote: > > > > > From: Luca Boccassi > > > > > > If enabled, we fallback to the platform keyring if the trusted keyring > > > doe

Re: [PATCH] dm-verity: restart or panic on an I/O error

2024-09-24 Thread Akilesh Kailash
On Tue, Sep 24, 2024 at 10:44 AM Sami Tolvanen wrote: > > Hi Mikulas, > > On Tue, Sep 24, 2024 at 6:18 AM Mikulas Patocka wrote: > > > > Maxim Suhanov reported that dm-verity doesn't crash if an I/O error > > happens. In theory, this could be used to subvert security, because an > > attacker can

Re: [PATCH] dm-verity: restart or panic on an I/O error

2024-09-24 Thread Mikulas Patocka
On Tue, 24 Sep 2024, Sami Tolvanen wrote: > Hi Mikulas, > > On Tue, Sep 24, 2024 at 6:18 AM Mikulas Patocka wrote: > > > > Maxim Suhanov reported that dm-verity doesn't crash if an I/O error > > happens. In theory, this could be used to subvert security, because an > > attacker can create sect

Re: [PATCH] dm-verity: restart or panic on an I/O error

2024-09-24 Thread Sami Tolvanen
Hi Mikulas, On Tue, Sep 24, 2024 at 6:18 AM Mikulas Patocka wrote: > > Maxim Suhanov reported that dm-verity doesn't crash if an I/O error > happens. In theory, this could be used to subvert security, because an > attacker can create sectors that return error with the Write Uncorrectable > comman

Re: [PATCH] dm verity: fallback to platform keyring also if key in trusted keyring is rejected

2024-09-24 Thread Jarkko Sakkinen
On Mon Sep 23, 2024 at 5:04 PM EEST, Mikulas Patocka wrote: > > > On Sun, 22 Sep 2024, luca.bocca...@gmail.com wrote: > > > From: Luca Boccassi > > > > If enabled, we fallback to the platform keyring if the trusted keyring > > doesn't have > > the key used to sign the roothash. But if pkcs7_veri

Re: [PATCH v1] md: Correct typos in multiple comments across various files

2024-09-24 Thread Mikulas Patocka
Hi I've applied the device mapper part of the patch. Mikulas On Tue, 24 Sep 2024, Shen Lichuan wrote: > Fixed some confusing spelling errors that were currently identified, > the details are as follows: > > -in the code comments: > writeback.c: 124: overrite==> ove

[PATCH] dm-verity: restart or panic on an I/O error

2024-09-24 Thread Mikulas Patocka
Maxim Suhanov reported that dm-verity doesn't crash if an I/O error happens. In theory, this could be used to subvert security, because an attacker can create sectors that return error with the Write Uncorrectable command. Some programs may misbehave if they have to deal with EIO. This commit f

[PATCH v1] md: Correct typos in multiple comments across various files

2024-09-24 Thread Shen Lichuan
Fixed some confusing spelling errors that were currently identified, the details are as follows: -in the code comments: writeback.c: 124: overrite==> overwrite dm-cache-target.c: 1371:exclussive ==> exclusive dm-raid.c: 2522:

Re: [PATCH v2 1/3] dm-inlinecrypt: Add inline encryption support

2024-09-24 Thread Christoph Hellwig
On Sat, Sep 21, 2024 at 11:55:19AM -0700, Eric Biggers wrote: > (https://android.googlesource.com/kernel/common/+/refs/heads/android-mainline/drivers/md/dm-default-key.c), > and I've been looking for the best way to get the functionality upstream. The > main challenge is that dm-default-key is int