Re: [PATCH md-6.10 3/9] md: add new helpers for sync_action

2024-05-13 Thread Xiao Ni
On Mon, May 13, 2024 at 5:31 PM Yu Kuai wrote: > > From: Yu Kuai > > The new helpers will get current sync_action of the array, will be used > in later patches to make code cleaner. > > Signed-off-by: Yu Kuai > --- > drivers/md/md.c | 64 + > driv

Re: [PATCH md-6.10 1/9] md: rearrange recovery_flage

2024-05-13 Thread Xiao Ni
On Tue, May 14, 2024 at 2:16 PM Yu Kuai wrote: > > Hi, > > 在 2024/05/14 13:51, Xiao Ni 写道: > > On Mon, May 13, 2024 at 9:57 AM Yu Kuai wrote: > >> > >> From: Yu Kuai > >> > >> Currently there are lots of flags and the names are confusing, since > >> there are two main types of flags, sync thread

Re: [PATCH md-6.10 2/9] md: add a new enum type sync_action

2024-05-13 Thread Xiao Ni
On Mon, May 13, 2024 at 6:19 PM Yu Kuai wrote: > > From: Yu Kuai > > In order to make code related to sync_thread cleaner in following > patches, also add detail comment about each sync action. > > Signed-off-by: Yu Kuai > --- > drivers/md/md.h | 57 +

Re: [PATCH md-6.10 1/9] md: rearrange recovery_flage

2024-05-13 Thread Yu Kuai
Hi, 在 2024/05/14 13:51, Xiao Ni 写道: On Mon, May 13, 2024 at 9:57 AM Yu Kuai wrote: From: Yu Kuai Currently there are lots of flags and the names are confusing, since there are two main types of flags, sync thread runnng status and sync thread action, rearrange and update comment to improve

Re: [PATCH md-6.10 1/9] md: rearrange recovery_flage

2024-05-13 Thread Xiao Ni
On Mon, May 13, 2024 at 9:57 AM Yu Kuai wrote: > > From: Yu Kuai > > Currently there are lots of flags and the names are confusing, since > there are two main types of flags, sync thread runnng status and sync > thread action, rearrange and update comment to improve code readability, > there are

Re: [PATCH md-6.10 1/9] md: rearrange recovery_flage

2024-05-13 Thread Yu Kuai
Hi, 在 2024/05/13 23:12, Mariusz Tkaczyk 写道: On Thu, 9 May 2024 09:18:52 +0800 Yu Kuai wrote: There is typo in subject. Yes, :) From: Yu Kuai Currently there are lots of flags and the names are confusing, since there are two main types of flags, sync thread runnng status and sync thread

Re: [PATCH 7/7] multipath-tools man pages: Add format wildcard descriptions

2024-05-13 Thread Benjamin Marzinski
On Mon, May 13, 2024 at 01:36:46PM -0400, Benjamin Marzinski wrote: > Suggested-by: Nitin Yewale > Signed-off-by: Benjamin Marzinski Oops. I forgot to update the man page date. Martin, either I can send a new patch or you can feel free to update the date when you apply this one, whichever you'd

[PATCH 6/7] libmultipath: change the vend/prod/rev printing

2024-05-13 Thread Benjamin Marzinski
The %s multipath and path wildcards both say they print the device vend/prod/rev string, but neither of them do. The multipath wildcards already provide a way to print the revision string and the %s wildcard is used in the multipath -l output, so leave the wildcard output alone, and change the desc

[PATCH 5/7] multipath-tools man pages: add missing multipathd commands

2024-05-13 Thread Benjamin Marzinski
Also, the description for "del map $map" was incorrect. Signed-off-by: Benjamin Marzinski --- multipathd/multipathd.8.in | 42 +- 1 file changed, 37 insertions(+), 5 deletions(-) diff --git a/multipathd/multipathd.8.in b/multipathd/multipathd.8.in index 06d91

[PATCH 2/7] multipath-tools man pages: don't assume multipath.socket is enabled

2024-05-13 Thread Benjamin Marzinski
Add "If enabled, " to the sentence about multipathd.socket, since it is no longer enabled by default. Signed-off-by: Benjamin Marzinski --- multipathd/multipathd.8.in | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/multipathd/multipathd.8.in b/multipathd/multipa

[PATCH 1/7] libmultipath: remove pathgroup wildcard options

2024-05-13 Thread Benjamin Marzinski
From: Nitin Yewale The multipathd command "multipathd show wildcards" shows the pathgroup format wildcards, but there is no way to use them in a multipathd command. Signed-off-by: Benjamin Marzinski --- libmultipath/print.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/libmultipath

[PATCH 7/7] multipath-tools man pages: Add format wildcard descriptions

2024-05-13 Thread Benjamin Marzinski
Suggested-by: Nitin Yewale Signed-off-by: Benjamin Marzinski --- multipathd/multipathd.8.in | 211 - 1 file changed, 207 insertions(+), 4 deletions(-) diff --git a/multipathd/multipathd.8.in b/multipathd/multipathd.8.in index 32976052..ff150f3d 100644 --- a/m

[PATCH 3/7] libmultipath: print all values in snprint_failback

2024-05-13 Thread Benjamin Marzinski
Add the missing output for manual failback and print the defferral time for deferred failbacks, if one isn't currently in progress. Signed-off-by: Benjamin Marzinski --- libmultipath/print.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libmultipath/print.c b/libmultip

[PATCH 4/7] multipathd: Stop double counting map failures for no_path_retry > 0

2024-05-13 Thread Benjamin Marzinski
If no_path_retry was greater than 0, multipathd was counting a map failure when recovery mode was entered, and again when queueing was disabled. The first one is incorrect, since the map is still queueing. Signed-off-by: Benjamin Marzinski --- libmultipath/structs_vec.c | 5 - 1 file changed

[PATCH 0/7] multipath-tools man pages: add missing information

2024-05-13 Thread Benjamin Marzinski
This patchset is inspired by: https://lore.kernel.org/dm-devel/1673555329-9850-1-git-send-email-bmarz...@redhat.com/ It removes the useless pathgroup wildcards section from the "show wildcards" output and adds wildcards descriptions to the multipathd.8 man page, along with some issing multipathd c

Re: [PATCH md-6.10 1/9] md: rearrange recovery_flage

2024-05-13 Thread Mariusz Tkaczyk
On Thu, 9 May 2024 09:18:52 +0800 Yu Kuai wrote: There is typo in subject. > From: Yu Kuai > > Currently there are lots of flags and the names are confusing, since > there are two main types of flags, sync thread runnng status and sync > thread action, rearrange and update comment to improve