Re: [PATCH -next 0/9] dm-raid, md/raid: fix v6.7 regressions part2

On Mon, Mar 4, 2024 at 9:24 AM Yu Kuai wrote: > > Hi, > > 在 2024/03/04 9:07, Yu Kuai 写道: > > Hi, > > > > 在 2024/03/03 21:16, Xiao Ni 写道: > >> Hi all > >> > >> There is a error report from lvm regression tests. The case is > >> lvconvert-raid-reshape-stripes-load-reload.sh. I saw this error when I

Re: [PATCH -next 0/9] dm-raid, md/raid: fix v6.7 regressions part2

Hi, 在 2024/03/04 9:07, Yu Kuai 写道: Hi, 在 2024/03/03 21:16, Xiao Ni 写道: Hi all There is a error report from lvm regression tests. The case is lvconvert-raid-reshape-stripes-load-reload.sh. I saw this error when I tried to fix dmraid regression problems too. In my patch set,  after reverting ad

Re: [PATCH -next 0/9] dm-raid, md/raid: fix v6.7 regressions part2

Hi, 在 2024/03/03 21:16, Xiao Ni 写道: Hi all There is a error report from lvm regression tests. The case is lvconvert-raid-reshape-stripes-load-reload.sh. I saw this error when I tried to fix dmraid regression problems too. In my patch set, after reverting ad39c08186f8a0f221337985036ba86731d6aaf

[PATCH 11/11] block: remove disk_stack_limits

disk_stack_limits is unused now, remove it. Signed-off-by: Christoph Hellwig Reviewed--by: Song Liu Tested-by: Song Liu --- block/blk-settings.c | 24 include/linux/blkdev.h | 2 -- 2 files changed, 26 deletions(-) diff --git a/block/blk-settings.c b/block/blk-sett

[PATCH 09/11] md: don't initialize queue limits

Initial queue limits are now set from ->run. Remove the superfluous initialization in md_alloc and level_store. Signed-off-by: Christoph Hellwig Reviewed--by: Song Liu Tested-by: Song Liu --- drivers/md/md.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/md/md.c b/drivers/md/md.

[PATCH 10/11] md: remove mddev->queue

Just use the request_queue from the gendisk pointer in the relatively few places that sill need it. Signed-off-by: Christoph Hellwig Reviewed--by: Song Liu Tested-by: Song Liu --- drivers/md/md.c| 22 -- drivers/md/md.h| 5 ++--- drivers/md/raid0.c | 2

[PATCH 08/11] md/raid10: use the atomic queue limit update APIs

Build the queue limits outside the queue and apply them using queue_limits_set. To make the code more obvious also split the queue limits handling into separate helpers. Signed-off-by: Christoph Hellwig Reviewed--by: Song Liu Tested-by: Song Liu --- drivers/md/raid10.c | 60 +

[PATCH 07/11] md/raid5: use the atomic queue limit update APIs

Build the queue limits outside the queue and apply them using queue_limits_set. To make the code more obvious also split the queue limits handling into separate helpers. Signed-off-by: Christoph Hellwig Reviewed--by: Song Liu Tested-by: Song Liu --- drivers/md/raid5.c | 130 ++

[PATCH 06/11] md/raid1: use the atomic queue limit update APIs

Build the queue limits outside the queue and apply them using queue_limits_set. To make the code more obvious also split the queue limits handling into a separate helper function. Signed-off-by: Christoph Hellwig Reviewed--by: Song Liu Tested-by: Song Liu --- drivers/md/raid1.c | 25 +

[PATCH 05/11] md/raid0: use the atomic queue limit update APIs

Build the queue limits outside the queue and apply them using queue_limits_set. To make the code more obvious also split the queue limits handling into a separate helper function. Signed-off-by: Christoph Hellwig Reviewed--by: Song Liu Tested-by: Song Liu --- drivers/md/raid0.c | 35 +

[PATCH 04/11] md: add queue limit helpers

Add a few helpers that wrap the block queue limits API for use in MD. Signed-off-by: Christoph Hellwig Reviewed--by: Song Liu Tested-by: Song Liu --- drivers/md/md.c | 45 + drivers/md/md.h | 3 +++ 2 files changed, 48 insertions(+) diff --git a/dr

[PATCH 03/11] md: add a mddev_is_dm helper

Add a helper to check for a DM-mapped MD device instead of using the obfuscated ->gendisk or ->queue NULL checks. Signed-off-by: Christoph Hellwig Reviewed--by: Song Liu Tested-by: Song Liu --- drivers/md/md.c | 15 +++ drivers/md/md.h | 12 ++-- drivers/md/raid0.c

[PATCH 02/11] md: add a mddev_add_trace_msg helper

Add a small wrapper around blk_add_trace_msg that hides some argument dereferences and the check for a DM-mapped MD device. Signed-off-by: Christoph Hellwig Reviewed--by: Song Liu Tested-by: Song Liu --- drivers/md/md-bitmap.c | 9 +++-- drivers/md/md.c| 3 +-- drivers/md/md.h

[PATCH 01/11] md: add a mddev_trace_remap helper

Add a helper to trace bio remapping that hides some argument dereferences and the check for a DM-mapped MD device. Signed-off-by: Christoph Hellwig Reviewed--by: Song Liu Tested-by: Song Liu --- drivers/md/md.c | 6 +- drivers/md/md.h | 8 drivers/md/raid0.c | 5 +